Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add routeSettings, transitionBuilder and navigatorKey Parameters to Dialog Methods #37

Merged

Conversation

codermuss
Copy link
Contributor

Description:
It would be beneficial if showDialog, showCustomDialog, and related methods provided additional parameters to enhance customization options:

•	RouteSettings? routeSettings
•	GlobalKey<NavigatorState>? navigatorKey
•	RouteTransitionsBuilder? transitionBuilder,

Use Case:
These parameters would allow:

•	Custom Routing: routeSettings would enable setting a name and arguments for the dialog’s route, which can assist in analytics and tracking.
•	Navigator Targeting: navigatorKey would provide flexibility to show dialogs in specific navigator instances, which is helpful in applications with multiple navigators or nested navigation.
•	Custom Transitions: transitionBuilder would allow for custom transition animations when displaying dialogs. This is useful for creating a unique user experience or matching the dialog transitions with the app’s design style.

Example image for routing log:
The first line is without routeSettings parameter. The second line is with routeSettings parameter.
Screenshot 2024-11-05 at 20 28 11

Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really cool PR man!

Thank you. I really like the transition on the custom dialog.

Thanks

@FilledStacks FilledStacks merged commit a4c9c57 into Stacked-Org:main Nov 7, 2024
1 check failed
@FilledStacks
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants