Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing the argument name refactoring from Stacked 3.0 #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BLKKKBVSIK
Copy link

In this PR:

  • Updating the Readme, the example code & the implementation to prefer the 'viewModel' argument name instead of 'model'

FilledStacks
FilledStacks previously approved these changes Apr 10, 2023
@FilledStacks
Copy link
Contributor

@BLKKKBVSIK good catch and thank you form making a PR! I appreciate it.

@FilledStacks
Copy link
Contributor

@BLKKKBVSIK check out the analyze issue. Run it locally in the repo and you'll see the same output.

@BLKKKBVSIK
Copy link
Author

Should be OK now.

@FilledStacks
Copy link
Contributor

@BLKKKBVSIK still analyze issues. Run it locally before you push so you can see if all issue are fixed.

@BLKKKBVSIK
Copy link
Author

Hi @FilledStacks, sorry for the late reply.

The checks doesn't pass because of the generated mocks, so I tried to regenerate the mocks using the build_runner, but it seems that there is a deeper problem with the service locator:

flutter pub run build_runner build
[INFO] Generating build script...
[INFO] Generating build script completed, took 209ms

[INFO] Precompiling build script......
[WARNING] ../../../.pub-cache/hosted/pub.dev/stacked_core-1.2.4/lib/src/code_generation/locator/stacked_locator.dart:405:19: Error: The argument type 'Object?' can't be assigned to the parameter type 'T?'.
 - 'Object' is from 'dart:core'.
        instance: instance,
                  ^
[INFO] Precompiling build script... completed, took 3.4s

[SEVERE] Failed to precompile build script .dart_tool/build/entrypoint/build.dart.
This is likely caused by a misconfigured builder definition.

pub finished with exit code 78

@BLKKKBVSIK
Copy link
Author

Up @FilledStacks.
Would love to resolve this issue with your insights.

@FilledStacks
Copy link
Contributor

@BLKKKBVSIK sorry for the late response. I was very busy trying to complete the Stacked Flutter Web course which released today.

I'm going to review again now and see what's causing the issue

@FilledStacks
Copy link
Contributor

@BLKKKBVSIK

  • Update to stacked_generator: ^1.3.3
  • Run flutter pub upgrade in example app
  • Re-run stacked generate in the example app

Push those changes and it should pass. Then I'll merge it in.

@BLKKKBVSIK
Copy link
Author

@FilledStacks Should be good now, but can't see the output of the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants