-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuing the argument name refactoring from Stacked 3.0 #8
base: main
Are you sure you want to change the base?
Conversation
@BLKKKBVSIK good catch and thank you form making a PR! I appreciate it. |
@BLKKKBVSIK check out the analyze issue. Run it locally in the repo and you'll see the same output. |
Should be OK now. |
@BLKKKBVSIK still analyze issues. Run it locally before you push so you can see if all issue are fixed. |
Hi @FilledStacks, sorry for the late reply. The checks doesn't pass because of the generated mocks, so I tried to regenerate the mocks using the build_runner, but it seems that there is a deeper problem with the service locator:
|
Up @FilledStacks. |
@BLKKKBVSIK sorry for the late response. I was very busy trying to complete the Stacked Flutter Web course which released today. I'm going to review again now and see what's causing the issue |
Push those changes and it should pass. Then I'll merge it in. |
@FilledStacks Should be good now, but can't see the output of the CI. |
In this PR: