Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rodio to 0.17.1 and cpal to 0.15.1 #1191

Closed
wants to merge 1 commit into from

Conversation

shatteringlass
Copy link

Solves #745

@eladyn
Copy link
Member

eladyn commented Mar 17, 2023

Thank you for the suggestion! Unfortunately, updating that dependency isn't as easy as updating Cargo.lock.

➜ cargo tree --invert=rodio --all-features
rodio v0.13.1
└── librespot-playback v0.2.0
    ├── librespot-connect v0.2.0
    │   └── spotifyd v0.3.4 (/home/user/spotifyd)
    └── spotifyd v0.3.4 (/home/user/spotifyd)

As you can see, we pull in the dependency only indirectly through librespot-playback. And even on the current dev version, their Cargo.toml requires the older rodio version.

(Compiling your version with --locked fails with: error: the lock file /home/user/spotifyd/Cargo.lock needs to be updated but --locked was passed to prevent this.)

So what should instead be done is making a PR to librespot that updates their Cargo.toml and fixes the potential compilation errors that arise from this. :)

@shatteringlass
Copy link
Author

Very sorry about the issue, I'm not expert with Rust at all and I shouldn't have messed up with Cargo :)
But because I'd like to help solve the issue I have opened this PR on librespot and hopefully it works this time.

@eladyn
Copy link
Member

eladyn commented Mar 18, 2023

Sure, no worries! Regarding your changes to librespot, you'll need to upgrade jack to “0.5” as well, since otherwise there are dependency conflicts on the jack-sys crate between jack and cpal. But otherwise, I think you could submit that PR. :)

@shatteringlass shatteringlass deleted the patch-1 branch March 22, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants