Skip to content

Commit

Permalink
update contrib
Browse files Browse the repository at this point in the history
  • Loading branch information
jackaraz committed Dec 13, 2024
1 parent ca2323b commit 5b5f057
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 15 deletions.
14 changes: 8 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@ If your proposed changes are more extensive than a few lines of code, please cre
Follow these steps to submit a pull request:

1. Fork the `spey` repository.
2. Open an issue and discuss the implementation with the developers.
3. Commit your changes to a feature branch on your fork and push all your changes.
4. Start a draft pull request and inform the developers about your progress.
5. Pull the ``main`` branch to ensure there are no conflicts with the current code developments.
6. Modify the appropriate section of
2. Install pre-commit using `pip install pre-commit`
3. Go to `spey` main folder and type `pre-commit install`.
4. Open an issue and discuss the implementation with the developers.
5. Commit your changes to a feature branch on your fork and push all your changes.
6. Start a draft pull request and inform the developers about your progress.
7. Pull the ``main`` branch to ensure there are no conflicts with the current code developments.
8. Modify the appropriate section of
`docs/releases/changelog-dev.md`.
7. Once complete, request a review from one of the maintainers.
9. Once complete, request a review from one of the maintainers.

#### Docstring style

Expand Down
18 changes: 10 additions & 8 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,15 @@ Pull request procedure

Follow these steps to submit a pull request:

1. Fork the ``spey`` repository.
2. Open an issue and discuss the implementation with the developers.
3. Commit your changes to a feature branch on your fork and push all your changes.
4. Start a draft pull request and inform the developers about your progress.
5. Pull the ``main`` branch to ensure there are no conflicts with the current code developments.
6. Modify the appropriate section of ``docs/releases/changelog-dev.md``.
7. Once complete, request a review from one of the maintainers.
1. Fork the `spey` repository.
2. Install pre-commit using `pip install pre-commit`
3. Go to `spey` main folder and type `pre-commit install`.
4. Open an issue and discuss the implementation with the developers.
5. Commit your changes to a feature branch on your fork and push all your changes.
6. Start a draft pull request and inform the developers about your progress.
7. Pull the ``main`` branch to ensure there are no conflicts with the current code developments.
8. Modify the appropriate section of `docs/releases/changelog-dev.md`.
9. Once complete, request a review from one of the maintainers.

Docstring style
~~~~~~~~~~~~~~~
Expand Down Expand Up @@ -66,5 +68,5 @@ Throughout the code, the following documentation style has been employed
{{descriptionPlaceholder}}
{{/returns}}
This code can directly be imported into ``custom.mustache`` file and used within
This script can directly be imported into ``custom.mustache`` file and used within
vscode as an auto docstring generator.
2 changes: 1 addition & 1 deletion src/spey/base/hypotest_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __dir__():

log = logging.getLogger("Spey")

# pylint: disable=W1203,C0103
# pylint: disable=W1203,C0103,possibly-used-before-assignment


class HypothesisTestingBase(ABC):
Expand Down

0 comments on commit 5b5f057

Please sign in to comment.