Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix faq ciab descr link #292

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix/fix faq ciab descr link #292

merged 3 commits into from
Jan 24, 2025

Conversation

garloff
Copy link
Member

@garloff garloff commented Jan 23, 2025

In the intro "about", the link to CiaB was broken.
Furthermore, it talked about CiaB as a virtual deployment.
While CiaB can be deployed virtually, it is typically not. The point of CiaB is that it's a single-node deployment.

Being at it:

  • Fixing the testbed links.
  • Move the mentioning that the ref. impl. for virtualization (IaaS) layer is from OSISM ahead of the deployment examples.
  • Mention artcodix and HW labs there as well.
  • Mention Cluster-Stacks from syself as ref.impl. as well ahead of the description (to have the same structure)

It can be deployed in a VM, but most of the time is not.

Fix link to CiaB docs.

Restructure the sections a bit.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff garloff requested review from berendt and maxwolfs January 23, 2025 18:19
@garloff garloff added the documentation Improvements or additions to documentation label Jan 23, 2025
@garloff garloff self-assigned this Jan 23, 2025
@garloff
Copy link
Member Author

garloff commented Jan 23, 2025

Cherry-picked to staging in case you want to view the result ...

docs/index.mdx Outdated

#### Quick Start with Cloud-In-A-Box

The fastest way to get in touch with SCS is to deploy a SCS cloud virtually. The Cloud-In-A-Box was built explicitly for this scenario. Check it out [here](/docs/iaas/guides/deploy-guide/examples/cloud-in-a-box)
You can do a single node installation for learning, testing or development purposes.
The Cloud-In-A-Box configuration was built explicitly for this scenario.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud in a Box

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, while I agree in a being lowercase, I consider the term Cloud-in-a-Box a single term rather than four words ... thus my preference to leave the hyphens in it. I believe we have used the form with hyphens at most places in the past. If we want to change that, we should probably grep through our repos and address it everywhere ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially addressed by 9fc2e2f.

docs/index.mdx Outdated Show resolved Hide resolved
docs/index.mdx Outdated Show resolved Hide resolved
docs/index.mdx Outdated
### Container Layer

The Reference Implementation (v2) for the container (Kubernetes-as-a-Services = KaaS) layer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference implementation? If Reference Implemention is correct it has to be changed in line 21.

Kubernetes-as-a-Services -> Kubernetes as a Service

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I capitalized Reference Implementation at both places now, giving it the property of a name. See 9fc2e2f.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not removed the hyphens from Kubernetes-as-a-Service ... I consider this a single word.

docs/index.mdx Outdated Show resolved Hide resolved
In particular:
- Capitalize Reference Implementation and Ceph.
- Decapitalize the in-a from Cloud-in-a-Box.
- Remove extra 's' from Kubernetes-as-a-Service*s*.
- Use internal links where possible.

Signed-off-by: Kurt Garloff <[email protected]>
@garloff
Copy link
Member Author

garloff commented Jan 24, 2025

Thanks for your diligent review, @berendt !
I have addressed most of your suggestions, though not all.
@dirklossack always wanted me to use more hyphens than I did, you seem to be arguing for fewer dashes ...
My personal taste is that when using well-defined terms such as CiaB, KaaS, ... I tend to consider them one word, which is why I run them together into one by using hyphens. I'm certainly not the only one doing this, but I'm happy to learn from folks with better English skills whether or not this is common or a no-go (or both ;-))

@berendt berendt self-requested a review January 24, 2025 10:00
@garloff garloff merged commit a64e1d9 into main Jan 24, 2025
5 checks passed
@garloff garloff deleted the fix/fix-faq-ciab-descr-link branch January 24, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants