-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Operator Docs Introduction #109
Conversation
Signed-off-by: Max Wolfs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the two TODO is this ready for review?
Well, except for the both TODOs it's ready for review. |
# Conflicts: # docs/index.md
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Jan Schoone <[email protected]>
Co-authored-by: Jan Schoone <[email protected]> Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
…reignCloudStack/docs into feat/refactor-operator-introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed some minor graphical issues with Max directly:
Here are more suggestions for some minor changes in wording.
Other than that, LGTM.
Signed-off-by: Max Wolfs <[email protected]>
Co-authored-by: Filip Dobrovolný <[email protected]> Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
f7dd985
to
27e697d
Compare
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Matej Feder <[email protected]>
Signed-off-by: Matej Feder <[email protected]>
Signed-off-by: Matej Feder <[email protected]>
Signed-off-by: Max Wolfs <[email protected]>
…reignCloudStack/docs into feat/refactor-operator-introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just two minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see also #152 - missing k8s-cluster-api-provider docs
Co-authored-by: Roman Hros <[email protected]> Signed-off-by: Max Wolfs <[email protected]>
Signed-off-by: Roman Hros <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked only at changes since my last review, looks perfect 👼
Co-authored-by: Roman Hros <[email protected]> Signed-off-by: Max Wolfs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* remove deprecated parts Signed-off-by: Max Wolfs <[email protected]> * fix linkg Signed-off-by: Max Wolfs <[email protected]> * feat: add cluster stacks description Signed-off-by: Jan Schoone <[email protected]> * Apply suggestions from code review Co-authored-by: Jan Schoone <[email protected]> Signed-off-by: Max Wolfs <[email protected]> * refactor components for better reuse with json Signed-off-by: Max Wolfs <[email protected]> * import architecture component Signed-off-by: Max Wolfs <[email protected]> * fix loading Signed-off-by: Max Wolfs <[email protected]> * Apply suggestions from code review Co-authored-by: Filip Dobrovolný <[email protected]> Signed-off-by: Max Wolfs <[email protected]> * add first single components to overview component Signed-off-by: Max Wolfs <[email protected]> * Adjust model Signed-off-by: Max Wolfs <[email protected]> * add custom data plugin Signed-off-by: Max Wolfs <[email protected]> * fix url Signed-off-by: Max Wolfs <[email protected]> * fix url Signed-off-by: Max Wolfs <[email protected]> * fix: typo Signed-off-by: Jan Schoone <[email protected]> * fix calendar link Signed-off-by: Max Wolfs <[email protected]> * Add container registry docs and display it on the overview map (SovereignCloudStack#143) Signed-off-by: Matej Feder <[email protected]> * Add monitoring docs and display it on the overview map (SovereignCloudStack#144) Signed-off-by: Matej Feder <[email protected]> * Add CSPO docs and display it on the overview map (SovereignCloudStack#149) Signed-off-by: Matej Feder <[email protected]> * fix component sizing Signed-off-by: Max Wolfs <[email protected]> * Apply suggestions from code review Co-authored-by: Roman Hros <[email protected]> Signed-off-by: Max Wolfs <[email protected]> * Add missing k8s-cluster-api-provider doc pages (SovereignCloudStack#152) Signed-off-by: Roman Hros <[email protected]> * fix title Co-authored-by: Roman Hros <[email protected]> Signed-off-by: Max Wolfs <[email protected]> --------- Signed-off-by: Max Wolfs <[email protected]> Signed-off-by: Jan Schoone <[email protected]> Signed-off-by: Matej Feder <[email protected]> Signed-off-by: Roman Hros <[email protected]> Co-authored-by: Jan Schoone <[email protected]> Co-authored-by: Filip Dobrovolný <[email protected]> Co-authored-by: Matej Feder <[email protected]> Co-authored-by: Roman Hros <[email protected]>
closes #103
closes #64
closes #136