Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQSCANGHA-59 Use the new way of having theme sensitive images. #168

Merged
merged 1 commit into from
Jan 21, 2025
Merged

SQSCANGHA-59 Use the new way of having theme sensitive images. #168

merged 1 commit into from
Jan 21, 2025

Conversation

henryju
Copy link
Member

@henryju henryju commented Jan 20, 2025 •
edited
Loading

SQSCANGHA-59

@antonio-garcia-sonarsource any reason why you did not use this way? I am not sure this will be better on the marketplace, but at least it seems to be the new recommended way.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Use the new way of having theme sensitive images. SQSCANGHA-78 Use the new way of having theme sensitive images. Jan 20, 2025
@antonioaversa
Copy link
Contributor

@antonio-garcia-sonarsource any reason why you did not use this way? I am not sure this will be better on the marketplace, but at least it seems to be the new recommended way.

No, I was not aware of this HTML-based alternative. If it works in the marketplace, it's surely to be preferred.
Btw, I don't think we need to wait for next release - the marketplace displays the content of the master branch, so merging should be enough to see the result in the marketplace.

@antonioaversa
Copy link
Contributor

@henryju
I already created a JIRA issue when this problem first appeared: https://sonarsource.atlassian.net/browse/SQSCANGHA-59
You may want to link them and close one of the two as duplicate

@henryju henryju changed the title SQSCANGHA-78 Use the new way of having theme sensitive images. SQSCANGHA-59 Use the new way of having theme sensitive images. Jan 21, 2025
@henryju henryju enabled auto-merge (squash) January 21, 2025 08:43
@henryju henryju merged commit 6bbc136 into master Jan 21, 2025
55 checks passed
@henryju henryju deleted the jh/fix_logo branch January 21, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoine-vinot-sonarsource antoine-vinot-sonarsource antoine-vinot-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryju @antonioaversa @antoine-vinot-sonarsource