Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1696 SLI-1666 Adapt to new C# analyzer packaging #1223

Merged
merged 2 commits into from
Nov 12, 2024
Merged

SLI-1696 SLI-1666 Adapt to new C# analyzer packaging #1223

merged 2 commits into from
Nov 12, 2024

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Nov 8, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title .NET repackaging - WIP SLI-1696 .NET repackaging - WIP Nov 8, 2024
@nquinquenel nquinquenel changed the title SLI-1696 .NET repackaging - WIP SLI-1696 Adapt to new C# analyzer packaging Nov 8, 2024
@nquinquenel nquinquenel force-pushed the feature/dotnet-repackaging branch from 2fc4762 to 1ceae80 Compare November 8, 2024 16:30
@nquinquenel nquinquenel marked this pull request as ready for review November 8, 2024 16:31
@nquinquenel nquinquenel changed the title SLI-1696 Adapt to new C# analyzer packaging SLI-1696 SLI-1666 Adapt to new C# analyzer packaging Nov 11, 2024
@nquinquenel nquinquenel force-pushed the feature/dotnet-repackaging branch 2 times, most recently from 87351af to 337d50c Compare November 11, 2024 13:11
jblievremont
jblievremont approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jblievremont jblievremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a very minor nitpick 🔍

Validated in standalone mode (OSS) + connected mode with Peach (Enterprise).

src/main/java/org/sonarlint/intellij/core/BackendService.kt Outdated Show resolved Hide resolved
@nquinquenel nquinquenel force-pushed the feature/dotnet-repackaging branch from 337d50c to 732b69b Compare November 12, 2024 12:51
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nquinquenel nquinquenel merged commit cd4ec3e into master Nov 12, 2024
29 checks passed
@nquinquenel nquinquenel deleted the feature/dotnet-repackaging branch November 12, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblievremont jblievremont jblievremont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @jblievremont