Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMF-4065 Products rebranding in SonarLint #1221

Merged
merged 3 commits into from
Nov 18, 2024
Merged

MMF-4065 Products rebranding in SonarLint #1221

merged 3 commits into from
Nov 18, 2024

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Nov 8, 2024 •
edited by jira bot
Loading

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 8, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
2 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
22.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nquinquenel nquinquenel force-pushed the feature/mmf-4065-rebranding branch 3 times, most recently from 44f33b4 to e8cfe7d Compare November 18, 2024 08:06
@nquinquenel nquinquenel marked this pull request as ready for review November 18, 2024 08:09
@nquinquenel nquinquenel force-pushed the feature/mmf-4065-rebranding branch from e8cfe7d to 23f6d0f Compare November 18, 2024 09:05
thahnen
thahnen requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@thahnen thahnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look regarding the comments, it is mainly about inconsistency.

src/main/java/org/sonarlint/intellij/SonarLintIntelliJClient.kt Show resolved Hide resolved
src/main/java/org/sonarlint/intellij/messages/AnalysisListener.java Outdated Show resolved Hide resolved
src/main/java/org/sonarlint/intellij/config/project/ProjectExclusionsPanel.java Outdated Show resolved Hide resolved
@thahnen thahnen self-requested a review November 18, 2024 09:46
thahnen
thahnen approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@thahnen thahnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
4 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
30.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nquinquenel nquinquenel merged commit 31a34c1 into master Nov 18, 2024
33 checks passed
@nquinquenel nquinquenel deleted the feature/mmf-4065-rebranding branch November 18, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thahnen thahnen thahnen approved these changes

@eray-felek-sonarsource eray-felek-sonarsource Awaiting requested review from eray-felek-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @thahnen