Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1674 Update labels to match the rebranding #1220

Merged
merged 3 commits into from
Nov 8, 2024
Merged

SLI-1674 Update labels to match the rebranding #1220

merged 3 commits into from
Nov 8, 2024

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Nov 7, 2024 •
edited by jira bot
Loading

@nquinquenel nquinquenel marked this pull request as draft November 7, 2024 10:22
@nquinquenel nquinquenel force-pushed the task/nq/SLI-1688-rebranding-notif branch from ec9b6e5 to db3d222 Compare November 7, 2024 12:02
eray-felek-sonarsource
eray-felek-sonarsource approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eray-felek-sonarsource
eray-felek-sonarsource reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some tests needs to be adjusted

@nquinquenel nquinquenel force-pushed the task/nq/SLI-1688-rebranding-notif branch 2 times, most recently from 911ce55 to b9809e0 Compare November 7, 2024 12:33
@nquinquenel nquinquenel force-pushed the task/nq/SLI-1688-rebranding-notif branch from b9809e0 to c59f34d Compare November 7, 2024 12:58
@nquinquenel nquinquenel changed the title SLI-1688 Update notifications for rebranding SLI-1674 Update labels to match the rebranding Nov 7, 2024
@nquinquenel nquinquenel marked this pull request as ready for review November 8, 2024 08:22
@nquinquenel nquinquenel changed the base branch from feature/ef/SLI-1674-rebrand-labels to feature/mmf-4065-rebranding November 8, 2024 08:22
@nquinquenel nquinquenel merged commit e64e820 into feature/mmf-4065-rebranding Nov 8, 2024
29 checks passed
@nquinquenel nquinquenel deleted the task/nq/SLI-1688-rebranding-notif branch November 8, 2024 08:23
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 8, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
22.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

nquinquenel added a commit that referenced this pull request Nov 15, 2024
@nquinquenel
SLI-1674 Update labels to match the rebranding (#1220)
1133ee0
nquinquenel added a commit that referenced this pull request Nov 18, 2024
@nquinquenel
SLI-1674 Update labels to match the rebranding (#1220)
4327542
nquinquenel added a commit that referenced this pull request Nov 18, 2024
@nquinquenel
SLI-1674 Update labels to match the rebranding (#1220)
2322f6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eray-felek-sonarsource eray-felek-sonarsource eray-felek-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @eray-felek-sonarsource