Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1673 Change product logos to match the rebranding #1215

Merged
merged 1 commit into from
Nov 15, 2024
Merged

SLI-1673 Change product logos to match the rebranding #1215

merged 1 commit into from
Nov 15, 2024

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Nov 6, 2024 •
edited by jira bot
Loading

@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1673-rebranding-logo branch from 69fad34 to 376fdb1 Compare November 7, 2024 10:05
This was referenced Nov 8, 2024
Closed
Closed
@nquinquenel nquinquenel changed the base branch from master to feature/mmf-4065-rebranding November 8, 2024 08:22
@nquinquenel nquinquenel marked this pull request as ready for review November 8, 2024 08:22
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1673-rebranding-logo branch 3 times, most recently from 8944b22 to 57c1ef2 Compare November 11, 2024 13:48
@nquinquenel nquinquenel force-pushed the feature/nq/SLI-1673-rebranding-logo branch from 23ace81 to 0ca3a72 Compare November 15, 2024 14:24
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
21.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

thahnen
thahnen approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@thahnen thahnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the simplifications ^^

@nquinquenel nquinquenel merged commit a81a797 into feature/mmf-4065-rebranding Nov 15, 2024
32 checks passed
@nquinquenel nquinquenel deleted the feature/nq/SLI-1673-rebranding-logo branch November 15, 2024 15:54
nquinquenel added a commit that referenced this pull request Nov 15, 2024
@nquinquenel
SLI-1673 Change product logos to match the rebranding (#1215)
6dae7d8
nquinquenel added a commit that referenced this pull request Nov 15, 2024
@nquinquenel
SLI-1673 Change product logos to match the rebranding (#1215)
44f33b4
nquinquenel added a commit that referenced this pull request Nov 18, 2024
@nquinquenel
SLI-1673 Change product logos to match the rebranding (#1215)
e8cfe7d
nquinquenel added a commit that referenced this pull request Nov 18, 2024
@nquinquenel
SLI-1673 Change product logos to match the rebranding (#1215)
23f6d0f
nquinquenel added a commit that referenced this pull request Nov 18, 2024
@nquinquenel
SLI-1673 Change product logos to match the rebranding (#1215)
1653b26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thahnen thahnen thahnen approved these changes

@eray-felek-sonarsource eray-felek-sonarsource Awaiting requested review from eray-felek-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @thahnen