Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLI-593 Remove the module level configurable UI #1206

Merged
merged 1 commit into from
Oct 17, 2024
Merged

SLI-593 Remove the module level configurable UI #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 0 additions & 77 deletions src/main/java/org/sonarlint/intellij/config/module/SonarLintModuleConfigurable.java
View file
Open in desktop

This file was deleted.

124 changes: 0 additions & 124 deletions src/main/java/org/sonarlint/intellij/config/module/SonarLintModulePanel.form
View file
Open in desktop

This file was deleted.

60 changes: 0 additions & 60 deletions src/main/java/org/sonarlint/intellij/config/module/SonarLintModulePanel.java
View file
Open in desktop

This file was deleted.

18 changes: 1 addition & 17 deletions src/main/java/org/sonarlint/intellij/config/module/SonarLintModuleSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
import static org.sonarlint.intellij.common.util.SonarLintUtils.isBlank;

public final class SonarLintModuleSettings {
private String sqPathPrefix = "";
private String idePathPrefix = "";

private String projectKey = "";

public String getProjectKey() {
Expand All @@ -42,19 +41,4 @@ public void clearBindingOverride() {
this.projectKey = "";
}

public String getSqPathPrefix() {
return sqPathPrefix;
}

public void setSqPathPrefix(String sqPathPrefix) {
this.sqPathPrefix = sqPathPrefix;
}

public String getIdePathPrefix() {
return idePathPrefix;
}

public void setIdePathPrefix(String idePathPrefix) {
this.idePathPrefix = idePathPrefix;
}
}
1 change: 0 additions & 1 deletion src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@
<toolWindow id="SonarLint" anchor="bottom" icon="org.sonarlint.intellij.SonarLintIcons.SONARLINT_TOOLWINDOW_EMPTY" factoryClass="org.sonarlint.intellij.ui.SonarLintToolWindowFactory" canCloseContents="true"/>
<applicationConfigurable groupId="tools" id="sonarlint" displayName="SonarLint" instance="org.sonarlint.intellij.config.global.SonarLintGlobalConfigurable"/>
<projectConfigurable parentId="sonarlint" displayName="Project Settings" instance="org.sonarlint.intellij.config.project.SonarLintProjectConfigurable" nonDefaultProject="true"/>
<moduleConfigurable id="SonarLint" displayName="SonarLint" instance="org.sonarlint.intellij.config.module.SonarLintModuleConfigurable"/>
<colorSettingsPage implementation="org.sonarlint.intellij.config.SonarLintColorSettingsPage"/>
<checkinHandlerFactory implementation="org.sonarlint.intellij.trigger.SonarLintCheckinHandlerFactory"/>
<additionalTextAttributes scheme="Default" file="colorSchemes/SonarLintDefault.xml"/>
Expand Down
5 changes: 0 additions & 5 deletions src/test/java/org/sonarlint/intellij/AbstractSonarLintLightTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.time.Duration;
import java.util.Collections;
import java.util.List;
import java.util.Optional;
Expand All @@ -61,8 +60,6 @@
import org.sonarlint.intellij.ui.SonarLintConsoleTestImpl;

import static com.intellij.notification.NotificationsManager.getNotificationsManager;
import static org.assertj.core.api.Assertions.assertThat;
import static org.awaitility.Awaitility.await;
import static org.sonarlint.intellij.common.util.SonarLintUtils.getService;
import static org.sonarlint.intellij.config.Settings.getSettingsFor;

Expand Down Expand Up @@ -99,8 +96,6 @@ final void beforeEachLightTest(TestInfo testInfo) throws Exception {
getProjectSettings().setBindingEnabled(false);
getProjectSettings().setBindingSuggestionsEnabled(true);
setProjectLevelExclusions(Collections.emptyList());
getModuleSettings().setIdePathPrefix("");
getModuleSettings().setSqPathPrefix("");
getModuleSettings().clearBindingOverride();
getService(BackendService.class).moduleUnbound(getModule());
getService(BackendService.class).projectUnbound(getProject());
Expand Down
Loading