Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1603 Ensure UI thread does not call backend #1169

Merged
merged 7 commits into from
Sep 23, 2024
Merged

SLI-1603 Ensure UI thread does not call backend #1169

merged 7 commits into from
Sep 23, 2024

Conversation

eray-felek-sonarsource
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource commented Sep 17, 2024 •
edited by jira bot
Loading

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 66d005f to f66b791 Compare September 18, 2024 12:21
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch 3 times, most recently from 410f1a9 to 9215cee Compare September 18, 2024 14:53
@eray-felek-sonarsource eray-felek-sonarsource marked this pull request as ready for review September 18, 2024 15:33
nquinquenel
nquinquenel reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok but I think we can go further into the optimization - I will contribute as well based on your changes

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 5038240 to 858acc3 Compare September 19, 2024 10:23
@nquinquenel nquinquenel force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 858acc3 to adcee8b Compare September 19, 2024 12:54
eray-felek-sonarsource
eray-felek-sonarsource commented Sep 20, 2024
View reviewed changes
Copy link
Contributor Author

@eray-felek-sonarsource eray-felek-sonarsource left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments other than that LGTM

@nquinquenel nquinquenel force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 3fa9306 to 79bc2ea Compare September 20, 2024 14:02
@nquinquenel nquinquenel force-pushed the feature/ef/SLI-1603-ensure-backend-calls branch from 79bc2ea to e59de73 Compare September 23, 2024 13:49
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
25.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

nquinquenel
nquinquenel approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤞🏻

@nquinquenel nquinquenel merged commit c8da2f5 into master Sep 23, 2024
30 checks passed
@nquinquenel nquinquenel deleted the feature/ef/SLI-1603-ensure-backend-calls branch September 23, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nquinquenel nquinquenel nquinquenel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eray-felek-sonarsource @nquinquenel