SLI-1586 Sanitize preprocessorDefines before giving it to the analyzer
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terraform-techuser
changed the title
preprocessorDefines before giving it to the analyzerpreprocessorDefines before giving it to the analyzer
mpaladin
changed the title
preprocessorDefines before giving it to the analyzerpreprocessorDefines before giving it to the analyzer
mpaladin
force-pushed
the
mp/SLI-1586
branch
from
5102a4b to
60839f5
Compare
mpaladin
force-pushed
the
mp/SLI-1586
branch
from
60839f5 to
51fa676
Compare
nquinquenel
approved these changes
Sep 11, 2024
| class AnalyzerConfigurationTest { | ||
| @Test | ||
| void testPreprocessorDefines() { | ||
| OCCompilerSettings compilerSettings = mock(OCCompilerSettings.class); |
| when(compilerSettings.getPreprocessorDefines()).thenReturn(List.of( | ||
| "#define a b", "#define c d ", " #define e f ", " #define g h", " #define i j")); | ||
|
|
||
| String preprocessorDefines = AnalyzerConfiguration.getPreprocessorDefines(compilerSettings); |
There was a problem hiding this comment.
Suggested change
| String preprocessorDefines = AnalyzerConfiguration.getPreprocessorDefines(compilerSettings); | |
| var preprocessorDefines = AnalyzerConfiguration.getPreprocessorDefines(compilerSettings); |
|
nquinquenel
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLI-1586