Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes (dirty) the problem described in #6 #7

Closed
wants to merge 1 commit into from
Closed

Fixes (dirty) the problem described in #6 #7

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2015

I'm not sure how this was supposed to work, but I fixed the link problems (issue #6) so that year and month archives work again. I guess the system already looks for the non existing archive page, not the currently used taxonomy pages, to make the links work. As this page does not exist yet this is a quick and dirty fix for it.
I would love to make the "show more" button work, but I don't know what the functionality should look like - details welcome. ;)

I'm not sure how this was supposed to work, but I fixed the link problems (issue #6) so that year and month archives work again. I guess the system already looks for the non existing archive page, not the currently used taxonomy pages, to make the links work. As this page does not exist yet this is a quick and dirty fix for it. 
I would love to make the "show more" button work, but I don't know what the functionality should look like - details welcome. ;)
@Sommerregen
Copy link
Owner

Hi @mikewink ,

actually there is a bug in the Archive Plus plugin being responsible for #6. To be precise L76 of archive_plus.php should be

$archive = $this->grav['language']->translate(['PLUGINS.ARCHIVE_PLUS.NAME']);

Your dirty fix only works due to the presence of the Archives plugin, which sets thos taxonomies...

The show more button is a stub and is intended for future use. When truncating the archives list with the limit option the show more button shows up and will point to an archive page. Thus, even if you are truncating your archives list, you are able to see a list of all your posts then with an addtional click. I've already implemented an archive page. I only have to test my changes before releasing them.

@ghost
Copy link
Author

ghost commented Jan 21, 2016

Well let me know if you want to work together on a full fledged archive plugin for Grav 1+ in the future. I would like to join forces and create a solid and extensible solution. :)

@Sommerregen
Copy link
Owner

@mikewink The develop branch already have a bugfix for this. Closing as the dirty fix can be solved in an nicer way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant