Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archives not showing when no filters & no limits. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lamecarlate
Copy link

Hi!
I fixed some things that were behaving strangely on my Grav installation.

  • if filters were removed (in admin or in yml file), the collection was not created, now it is (I copied the "if" from official Archives plugin).
  • if limits were on "0", all months and all items were stripped from the archive.

* if filters are removed (in admin or in yml file), the collection was not created, now it is (I copied the "if" from official Archives plugin).
* if limits were to "0", all months and all items were stripped from the archive.
@Sommerregen
Copy link
Owner

Hi @Lamecarlate ,

thanks. That's great! 😄 Unfortunately, I have pushed some changes that conflicts with yours. Can you rebase your changes with the current develop branch?

@Lamecarlate
Copy link
Author

I must admit I've no idea of how to do that :/ I'm not very fluent with git, et these particular changes were done directly in Github…

@Sommerregen
Copy link
Owner

Ok, nevermind. Rebased your changes to the current development branch. It can be that my the changes in the develop branch already supersedes your PR and yours is not required anymore. However, as long as a new release is not published, go with your version 😃 .

@Lamecarlate
Copy link
Author

OK, thank you :)

(so, do I have to close this PR?)

@Sommerregen
Copy link
Owner

Hi @Lamecarlate ,

no you don't have to close this PR. It will be closed automatically when its merged into the develop branch or I will close it.

Just keep it open as a gentle reminder for me ;-)

@Caroga
Copy link

Caroga commented May 12, 2019

So, how's this PR holding against master now ? Cause a "all" function would greatly be appreciated, and any documentation on this would also be beneficially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants