BUG: Fix patient support rotation angle to fixed reference #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That bug was fixed in #236 commit, but appeared once again when IEC logic had been reworked. I don't know how that has happened, but it should work again. |
| @@ -397,7 +397,7 @@ void vtkSlicerBeamsModuleLogic::UpdateIECTransformsFromBeam(vtkMRMLRTBeamNode* b | |||
| // Set beam angles to IEC logic | |||
| this->IECLogic->UpdateGantryToFixedReferenceTransform(beamNode->GetGantryAngle()); | |||
| this->IECLogic->UpdateCollimatorToGantryTransform(beamNode->GetCollimatorAngle()); | |||
| this->IECLogic->UpdatePatientSupportRotationToFixedReferenceTransform(beamNode->GetCouchAngle()); | |||
| this->IECLogic->UpdatePatientSupportRotationToFixedReferenceTransform(-1. * beamNode->GetCouchAngle()); | |||
There was a problem hiding this comment.
If signs are flipped here, then the comment
// Set the inverse of the couch angle as now what moves is the room (treatment machine) around the patient,
// so the patient support table top (couch) always stays stationary in RAS.
should be moved from the other files to this one.
MichaelColonel
force-pushed
the
couch-angle-bug-again
branch
from
de3e449 to
e4fa460
Compare
How to test: 1. Load https://github.com/SlicerRt/SlicerRtData/tree/master/xio-4.64-phantom-prostate-beams-allnonzero from SlicerRtData. That dataset has predefined nonzero angles of beam orientation: gantry, couch, collimator. 2. Check in dose distribution lays within beam's model borders. 3. In "Beams" module check that beam orientation parameters are as follows: Gantry angle = 20 deg; Collimator angle = 350 deg; Couch angle = 300 deg. 4. In "Room's Eye View" module, load Varian machine and set required parameters for the machine sliders: Gantry angle = 20 deg; Collimator angle = 350 deg; Patient support rotation = -60 deg. (since slider range is from -180 up to 180 deg) 5. Go back to the "Beams" module and check that beam orientation parameters are the same: Gantry angle = 20 deg; Collimator angle = 350 deg; Couch angle = 300 deg.
|
Thank you very much! Since the two of you seem to agree that this works, I'm doing the merge (no time at all this week unfortunately). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Load https://github.com/SlicerRt/SlicerRtData/tree/master/xio-4.64-phantom-prostate-beams-allnonzero from SlicerRtData. That dataset has predefined nonzero angles of beam orientation: gantry, couch, collimator.
Check that dose distribution lays within beam's model borders.
In "Beams" module check that beam orientation parameters are as follows:
Gantry angle = 20 deg;
Collimator angle = 350 deg;
Couch angle = 300 deg.
In "Room's Eye View" module, load Varian machine and set required parameters for the machine sliders:
Gantry angle = 20 deg;
Collimator angle = 350 deg;
Patient support rotation = -60 deg. (since slider range is from -180 up to 180 deg)
Go back to the "Beams" module and check that beam orientation parameters are the same:
Gantry angle = 20 deg;
Collimator angle = 350 deg;
Couch angle = 300 deg.