Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: GUI upgrade of perspective projection calculation: #222

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

MichaelColonel
Copy link
Collaborator

  • QTableWidget to represent projected control points;
  • Project only selected or all control points;
  • Flag to created a new markups fiducial node for projected points.

@MichaelColonel
Copy link
Collaborator Author

New interface

image

* QTableWidget to represent projected control points;
* Project only selected or all control points;
* Flag to create a new markups fiducial node for
  projected points;
* Flag to create a new table node for projected points.
@cpinter
Copy link
Member

cpinter commented Nov 29, 2022

After a very quick glance it looks OK to me. One question so far: was there a specific reason for removing ModuleWindowInitialized? Thanks!

@MichaelColonel
Copy link
Collaborator Author

Module is quite simple and it doesn't require any specific GUI initiation. The GUI doesn't show beam node correctly if parameterNode was created in python console if you switch into module GUI for the first time with ModuleWindowInitialized.

@cpinter
Copy link
Member

cpinter commented Nov 29, 2022

Makes sense, thanks! I won't be able to do a thorough review, but since you are the main user/developer of the DRR module I'd simply accept this change. @Sunderlandkyl @lassoan please review if interested. I'll merge it in a day or two (unless you need it merged asap @MichaelColonel in which case I can do it now). Thanks again!

@MichaelColonel
Copy link
Collaborator Author

I thick it could be merged, so it could be tested by the user.

@lassoan lassoan merged commit 207589b into SlicerRt:master Dec 3, 2022
@lassoan
Copy link
Member

lassoan commented Dec 3, 2022

Thank you for all your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants