RN 40420 - Web API changes - Swarming #4083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wimme , can you please review this PR? |
wimme
reviewed
Jan 10, 2025
| > From DataMiner 10.6.0/10.5.1 onwards, when Swarming is enabled, use the [GetAlarmDetailsV2](xref:GetAlarmDetailsV2) method instead. | ||
|
|
||
| > [!NOTE] | ||
| > Use the [GetAlarmHistory](xref:GetAlarmHistory) or [GetAlarmHistoryV2](xref:GetAlarmHistoryV2) method to get the alarm details of a cleared non-root alarm. |
There was a problem hiding this comment.
I wouldn't recommend to use the old GetAlarmHistory method
|
I think we should flag the old methods more as deprecated. Even without using swarming, it's recommended to use the new methods. Also tagging @RobbeDGH as he might have additional feedback. |
RobbeDGH
reviewed
Jan 14, 2025
| | Item | Format | Description | | ||
| |-------------|---------|-------------| | ||
| | connection | String | The connection ID. See [ConnectApp](xref:ConnectApp). | | ||
| | dmaID | Integer | The DataMiner Agent ID. | |
There was a problem hiding this comment.
should we clarify this is the dataminer agent id of the element and not the agent currently hosting the element?
There was a problem hiding this comment.
(same for the other below)
| Use this method to retrieve the alarm details for a specified alarm. | ||
|
|
||
| > [!NOTE] | ||
| > Use the [GetAlarmHistory method](xref:GetAlarmHistory) to get the alarm details of a cleared non-root alarm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.