-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataset): prompt message to the user on push and pull #1507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to ca64fd3 in 47 seconds
More details
- Looked at
25
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. pandasai/dataframe/base.py:307
- Draft comment:
Use logging instead of print statements for better control over output and to avoid printing in production environments. - Reason this comment was not posted:
Marked as duplicate.
2. pandasai/dataframe/base.py:261
- Draft comment:
The print statement should be more descriptive. Consider changing it to:
print("Data pushed successfully.")
- Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The current print statement just prints the raw response data object, which may not be very readable or useful. The suggested change would make the output more user-friendly. However, the raw data might contain important response information that could be useful for debugging. The suggestion also assumes the push was successful, which may not always be true.
The suggested message assumes success but doesn't actually verify the response status. We might be hiding useful debugging information by not showing the response data.
A better suggestion would be to include both a descriptive message AND the response data, or to check the response status first. However, that's not what this comment suggests.
While the print statement could be improved, this specific suggestion is too simplistic and could hide useful information. The comment should be removed.
3. pandasai/dataframe/base.py:307
- Draft comment:
The print statement should be more descriptive. Consider changing it to:
print(f"Dataset successfully pulled from the path: {self.path}")
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_4DrgnpgQ8OTzcWAJ
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
pandasai/dataframe/base.py
Outdated
"/datasets/push", | ||
files=files, | ||
params=params, | ||
headers=headers, | ||
) | ||
print(data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use logging instead of print statements for better control over output and to avoid printing in production environments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 081928a in 27 seconds
More details
- Looked at
20
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. pandasai/dataframe/base.py:261
- Draft comment:
Consider including the dataset path or name in the print statement for more informative feedback. - Reason this comment was not posted:
Confidence changes required:50%
The print statement in thepush
method should provide more detailed feedback, such as including the dataset path or name, to make it more informative for the user.
2. pandasai/dataframe/base.py:261
- Draft comment:
The print statement can be more concise. Consider rephrasing it.
print("Dataset successfully pushed to Pandabi platform.")
- Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_xZW25dg03Ak42HRE
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add print statements in
push()
andpull()
inbase.py
for user feedback on dataset operations.push()
to confirm dataset push success.pull()
to confirm dataset pull success with path.This description was created by for 081928a. It will automatically update as commits are pushed.