Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pandasai.json): remove llm configs from pandasi json file #1504

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

ArslanSaleem
Copy link
Collaborator

@ArslanSaleem ArslanSaleem commented Jan 7, 2025

Important

Remove LLM configurations from pandasai.json and update module exports to include LocalLLM.

  • Configuration Changes:
    • Removed llm, llm_options from pandasai.json.
    • Updated load_config_from_json() in config.py to remove handling of llm and llm_options.
  • Documentation:
    • Removed references to llm and llm_options in docs/library.mdx and docs/llms.mdx.
  • Module Exports:
    • Added LocalLLM to __all__ in pandasai/llm/__init__.py.

This description was created by Ellipsis for 5ef9831. It will automatically update as commits are pushed.

@ArslanSaleem ArslanSaleem requested a review from gventuri January 7, 2025 09:42
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 7, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 10138ee in 8 seconds

More details
  • Looked at 32 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pandasai.json:11
  • Draft comment:
    The removal of "llm" and "llm_options" is consistent with the PR's intent to remove LLM configurations from the JSON file. Ensure that these configurations are not required elsewhere in the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR removes the 'llm' and 'llm_options' from the JSON file, which is consistent with the intent to remove LLM configurations from the JSON. The changes in the init.py file are consistent with the addition of LocalLLM to the list of imports and exports.
2. pandasai.json:11
  • Draft comment:
    Ensure the JSON file ends with a newline for better formatting and compatibility.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes are correct and do not introduce any grammar issues. The changes in the JSON file and the Python file are consistent with the PR title and description.

Workflow ID: wflow_SZXxBr2HWXWajjrV


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3cb822c in 8 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pandasai/llm/__init__.py:12
  • Draft comment:
    The import order of OpenAI was changed. While this doesn't affect functionality, it should be mentioned in the PR description for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import order was changed but it doesn't affect functionality. However, the PR description doesn't mention this change, which could be misleading.
2. pandasai/llm/__init__.py:12
  • Draft comment:
    No grammar or language issues in the modified lines.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The import statement for OpenAI was moved but not modified, so no grammar or language issues are present in the diff.

Workflow ID: wflow_FSmxlbq4vSvP6qcO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (cf33faa) to head (5ef9831).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1504   +/-   ##
=======================================
  Coverage   78.54%   78.55%           
=======================================
  Files         157      157           
  Lines        6325     6323    -2     
=======================================
- Hits         4968     4967    -1     
+ Misses       1357     1356    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 7, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 4be492d in 31 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pandasai/config.py:35
  • Draft comment:
    The check for config.get("llm") is unnecessary since the PR removes LLM configurations from pandasai.json. Consider removing this check to align with the PR's intent.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_UzqmErMHIjQuId84


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5ef9831 in 28 seconds

More details
  • Looked at 57 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/library.mdx:211
  • Draft comment:
    The documentation mentions modifying the pandasai.json file for configuration, but this PR removes llm and llm_options from it. Update the documentation to reflect the new configuration method.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. docs/llms.mdx:10
  • Draft comment:
    Use 'an LLM' instead of 'a LLM' for correct grammar. This issue appears in multiple places.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_nBF4kHfvn3c4fQam


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@gventuri gventuri merged commit 9ba5061 into main Jan 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants