New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to SMF\Time #8037

Merged

Sesquipedalian merged 2 commits into SimpleMachines:release-3.0 from Sesquipedalian:time_improvements

Jan 24, 2024

Member

Sesquipedalian commented Jan 24, 2024

Gives SMF\Time its own version of the setTimezone() method. This method can accept both \DateTimeZone objects and valid time zone identifiers as its argument, and returns an SMF\Time object rather than a \DateTime object.
Gives SMF\Time its own versions of the createFromInterface(), createFromMutable(), and createFromImmutable() methods.

This should fix #7985 and other issues like it in a generalized and permanent way.

Sesquipedalian added 2 commits

January 23, 2024 23:17


          Accept both strings and \DateTimeZone objs when setting Time->timezone

ba15a83

Signed-off-by: Jon Stovell <[email protected]>


          Adds createFromInterface() and friends to SMF\Time

8cf4aa4

Signed-off-by: Jon Stovell <[email protected]>

Sesquipedalian added this to the 3.0 Alpha 1 milestone

Sesquipedalian merged commit ca41b56 into SimpleMachines:release-3.0

3 checks passed

Sesquipedalian deleted the time_improvements branch

January 24, 2024 06:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet