Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some PM bugs #7947

Merged
merged 5 commits into from
Dec 24, 2023
Merged

Conversation

Oldiesmann
Copy link
Contributor

@Oldiesmann Oldiesmann commented Dec 9, 2023

This fixes four different PM-related bugs:

  • Error while trying to view a label for which no messages existed (including inbox)
  • Error while viewing search results if $_GET['start'] wasn't set
  • Error while searching PMs if no messages matched the given parameters
  • The PM popup wouldn't load because of a bad parameter being passed to the function to load messages

@Oldiesmann Oldiesmann changed the title Can't return something if it's never set... Fix some PM bugs Dec 9, 2023
Sources/PersonalMessage/Search.php Outdated Show resolved Hide resolved
Sources/PersonalMessage/Received.php Outdated Show resolved Hide resolved
@Sesquipedalian
Copy link
Member

I like this new feature where multiple suggestions can be committed in a single batch.

@Sesquipedalian Sesquipedalian merged commit 8443986 into SimpleMachines:release-3.0 Dec 24, 2023
2 of 3 checks passed
@Oldiesmann Oldiesmann deleted the fixpms branch December 25, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants