Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes random_compat library #7943

Merged

Conversation

Sesquipedalian
Copy link
Member

@Sesquipedalian Sesquipedalian commented Dec 5, 2023

Removes unnecessary random_compat library and improves various attempts to get random data.

Also fixes a bug where we weren't using bin2hex() on the random bytes inserted into the verification code URL in SMF\Actions\VerificationCode::execute().

Labelled as "PHP version support" because this was a polyfill library for PHP versions that we no longer need to support in 3.0.

@Sesquipedalian Sesquipedalian changed the title Remove random compat Removes random_compat library Dec 5, 2023
Copy link
Member

@jdarwood007 jdarwood007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Sesquipedalian Sesquipedalian merged commit 4fbac34 into SimpleMachines:release-3.0 Dec 6, 2023
3 checks passed
@Sesquipedalian Sesquipedalian deleted the remove_random_compat branch December 6, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants