Fix removing members from acp

SimpleMachines · Jan 20, 2024 · 8a2633e · 8a2633e
1 parent 97959a7
commit 8a2633e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/Sources/Actions/Admin/Membergroups.php b/Sources/Actions/Admin/Membergroups.php
@@ -640,7 +640,10 @@ public function edit(): void
 			ErrorHandler::fatalLang('membergroup_does_not_exist', false);
 		}
 
-		@list($group) = Group::load($_REQUEST['group']);
+		$groups = Group::load((int) $_REQUEST['group']);
+
+		/** @var \SMF\Group $group */
+		$group = array_shift($groups);
 
 		if (!isset($group) || !($group instanceof Group)) {
 			ErrorHandler::fatalLang('membergroup_does_not_exist', false);

diff --git a/Sources/Group.php b/Sources/Group.php
@@ -1203,6 +1203,9 @@ public function removeMembers(int|array $members, bool $perms_checked = false, b
 
 		// Load the user info for the members being removed.
 		$members = User::load($members, User::LOAD_BY_ID, 'minimal');
+		$members = array_map(function (\SMF\User $mem){
+			return $mem->id;
+		}, $members);
 
 		// Figure out which members should have their primary group changed and
 		// which should have their additional groups changed.