Uses correctly formed BBC in redirect links for moved & merged topics

Signed-off-by: Jon Stovell <[email protected]>
SimpleMachines · Jul 1, 2024 · 71e79e6 · 71e79e6
1 parent 7285205
commit 71e79e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Sources/MoveTopic.php b/Sources/MoveTopic.php
@@ -266,7 +266,7 @@ function MoveTopic2()
 	{
 		// Replace tokens with links in the reason.
 		$reason_replacements = array(
-			$txt['movetopic_auto_board'] => '[url="' . $scripturl . '?board=' . $_POST['toboard'] . '.0"]' . $board_name . '[/url]',
+			$txt['movetopic_auto_board'] => '[url=&quot;' . $scripturl . '?board=' . $_POST['toboard'] . '.0&quot;]' . $board_name . '[/url]',
 			$txt['movetopic_auto_topic'] => '[iurl]' . $scripturl . '?topic=' . $topic . '.0[/iurl]',
 		);
 
@@ -277,7 +277,7 @@ function MoveTopic2()
 
 			// Make sure we catch both languages in the reason.
 			$reason_replacements += array(
-				$txt['movetopic_auto_board'] => '[url="' . $scripturl . '?board=' . $_POST['toboard'] . '.0"]' . $board_name . '[/url]',
+				$txt['movetopic_auto_board'] => '[url=&quot;' . $scripturl . '?board=' . $_POST['toboard'] . '.0&quot;]' . $board_name . '[/url]',
 				$txt['movetopic_auto_topic'] => '[iurl]' . $scripturl . '?topic=' . $topic . '.0[/iurl]',
 			);
 		}

diff --git a/Sources/SplitTopics.php b/Sources/SplitTopics.php
@@ -1401,7 +1401,7 @@ function MergeExecute($topics = array())
 	{
 		// Replace tokens with links in the reason.
 		$reason_replacements = array(
-			$txt['movetopic_auto_topic'] => '[iurl="' . $scripturl . '?topic=' . $id_topic . '.0"]' . $target_subject . '[/iurl]',
+			$txt['movetopic_auto_topic'] => '[iurl=&quot;' . $scripturl . '?topic=' . $id_topic . '.0&quot;]' . $target_subject . '[/iurl]',
 		);
 
 		// Should be in the boardwide language.
@@ -1411,7 +1411,7 @@ function MergeExecute($topics = array())
 
 			// Make sure we catch both languages in the reason.
 			$reason_replacements += array(
-				$txt['movetopic_auto_topic'] => '[iurl="' . $scripturl . '?topic=' . $id_topic . '.0"]' . $target_subject . '[/iurl]',
+				$txt['movetopic_auto_topic'] => '[iurl=&quot;' . $scripturl . '?topic=' . $id_topic . '.0&quot;]' . $target_subject . '[/iurl]',
 			);
 		}