fix: 🐛live time indicator position on timeline is not correct when st… #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurva010
force-pushed
the
fix/issue_346_live_time_indicator_display_position
branch
from
4eadd8d to
2b8b656
Compare
apurva010
requested review from
vatsaltanna-simformsolutions
and removed request for
PRBaraiya
…artHour set in day and week view #346 - Removed/minus startHour minutes from totalMinutes of day to set dy offset of current timeline painter which set live time line indicator properly on timeline
apurva010
force-pushed
the
fix/issue_346_live_time_indicator_display_position
branch
from
2b8b656 to
8add974
Compare
vatsaltanna-simformsolutions
approved these changes
May 1, 2024
vatsaltanna-simformsolutions
deleted the
fix/issue_346_live_time_indicator_display_position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…artHour set in day and week view
Description
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #346
Before : live indicator in day view when startHour is set
After : live indicator in day view when startHour is set
Before : live indicator in week view when startHour is set
After : live indicator in week view when startHour is set