Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds Locale parameter to Calendar widgets #344

Closed
wants to merge 2 commits into from

Conversation

ahmetakil
Copy link
Contributor

Description

Currently there is no way to control the Date Picker's localization

This PR adds the locale field to DayView, WeekView and MonthView widgets which gets passed to the showDatePicker
If no locale is provided showDatePicker will behave the same way as it currently does.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@ParthBaraiya
Copy link
Collaborator

@ahmetakil Thank you very much for creating this PR. Unfortunately, we cannot merge it right now. Currently, there are many arguments in the CalendarView widget, making it complicated to use. Adding one more parameter would increase its complexity. Additionally, this parameter is passed in a function that can be overridden by passing builder methods to the respective widgets, rendering this argument unnecessary.

We might add this in the future once we figure out how to reorganize the widget parameters, but right now, we do not have any plans to add it. I suggest creating an issue to ensure this gets implemented in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants