chore: integrate goreleaser for user_scripts and restructuring #6911
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 12a9f0f in 14 seconds
More details
- Looked at
77lines of code in4files - Skipped
1files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. scripts/clickhouse/histogramquantile/.goreleaser.yaml:18
- Draft comment:
The 'main' field should specify the path to the main package, typically ending with a main.go file. Ensure the path is correct. - Reason this comment was not posted:
Comment did not seem useful.
2. Makefile:20
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. This rule is not violated in this PR, so no changes are needed here. - Reason this comment was not posted:
Confidence changes required:0%
The file structure approach usingcomponent/index.tsxis not present in the diff, so no comment is needed for that rule.
Workflow ID: wflow_BAEOdTwIsVtaBqsl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Signed-off-by: Prashant Shahi <[email protected]>
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 59fe968 in 34 seconds
More details
- Looked at
44lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. Makefile:196
- Draft comment:
No issues found related to the specified rules. - Reason this comment was not posted:
Confidence changes required:0%
The Makefile and .goreleaser.yaml files do not contain any violations of the specified rules. The changes in the Makefile are related to the integration of GoReleaser, and the .goreleaser.yaml file is properly structured for its purpose. No hardcoded colors, inline styles, or unrelated functions are present.
Workflow ID: wflow_uDchDAQ4uuJJQ9DO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
|
@prashant-shahi please create a corresponding PR on charts repo as well. |
Summary
Integrate goreleaser for
user_scriptsand restructuringRelated Issues / PR's
NA
Screenshots
NA
Affected Areas and Manually Tested Areas
NA
Important
Integrate GoReleaser for
user_scripts, restructure directories, and update Makefile with new targets..github/workflows/goreleaser.yamlfor GoReleaser on tag pushes.scripts/clickhouse/histogramquantile/.goreleaser.yamlfor GoReleaser configuration.CH_HISTOGRAM_QUANTILE_DIRECTORYvariable.goreleaser-snapshotandgoreleaser-snapshot-histogram-quantiletargets..deprecatedfile indeploy/docker/clickhouse-setup/user_scripts.histogramQuantile.gotomain.goand move toscripts/clickhouse/histogramquantile.This description was created by
for 59fe968. It will automatically update as commits are pushed.