Get data from json server api data in service sections

[ahmadshaheer]

Summary

Related Issues / PR's

Screenshots

NA

Affected Areas and Manually Tested Areas

---

Important

Integrate AWS service data retrieval and display in frontend components using new hooks and updated API calls.

• API Changes:
  • Modify getAwsServices in index.ts to return full data object instead of just services.
• Component Updates:
  • AccountActions.tsx: Update URL query and navigation when account changes.
  • RegionForm.tsx: Add form for selecting AWS regions with dynamic state updates.
  • ServiceDetails.tsx: Fetch and display service details dynamically using useServiceDetails hook.
  • ServicesList.tsx: Fetch and display list of services dynamically using useGetAccountServices hook.
  • ServicesTabs.tsx: Simplify service selection and display logic.
• Hooks:
  • Add useGetAccountServices and useServiceDetails hooks for fetching AWS data.
• Data and Types:
  • Update data.ts and types.ts to include new service configurations and types.

^{This description was created by for 075fdd2. It will automatically update as commits are pushed.}

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to bc62edb in 1 minute and 9 seconds

More details

• Looked at 336 lines of code in 9 files
• Skipped 0 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. frontend/src/hooks/integrations/aws/useGetAccountServices.ts:11

• Draft comment:
  The getAwsServices function was modified to return response.data.data instead of response.data.data.services. Ensure that the data structure returned by getAwsServices matches the expected structure in this hook.
• Reason this comment was not posted:
  Comment did not seem useful.

2. frontend/src/hooks/integrations/aws/useServiceDetails.ts:15

• Draft comment:
  Using !!serviceId to enable the query is a common practice to ensure the query is only enabled when serviceId is truthy. This is a minor change from Boolean(serviceId) and is acceptable.
• Reason this comment was not posted:
  Confidence changes required: 10%
  The useServiceDetails hook uses !!serviceId to enable the query, which is a common practice to ensure the query is only enabled when serviceId is truthy. This is a minor change from Boolean(serviceId) and is acceptable.

3. frontend/src/pages/Integrations/CloudIntegrationPage/HeroSection/AccountActions.tsx:80

• Draft comment:
  Avoid disabling react-hooks/exhaustive-deps. Ensure all dependencies are correctly listed in the dependency array to prevent unexpected behavior.
• Reason this comment was not posted:
  Comment did not seem useful.

4. frontend/src/pages/Integrations/CloudIntegrationPage/ServicesSection/ServiceDetails.tsx:57

• Draft comment:
  Ensure that serviceId and accountId are correctly retrieved from the URL query parameters. Defaulting to empty strings or undefined is a good practice to ensure valid parameters are passed to the hook.
• Reason this comment was not posted:
  Confidence changes required: 10%
  In ServiceDetails.tsx, the serviceId and accountId are retrieved from the URL query parameters. If these are not present, the hook defaults to empty strings or undefined. This is a good practice to ensure the hook is called with valid parameters.

5. frontend/src/pages/Integrations/CloudIntegrationPage/ServicesSection/ServicesList.tsx:19

• Draft comment:
  Ensure that activeService is initialized correctly. If services is not yet loaded, this might cause issues. Consider handling this case more gracefully.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_31kKuRDjzr1u7rGP

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[github-actions]

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

[ellipsis-dev]

👍 Looks good to me! Incremental review on 075fdd2 in 39 seconds

More details

• Looked at 15 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. frontend/src/container/CloudIntegrationPage/HeroSection/components/AccountActions.tsx:74

• Draft comment:
  The useEffect hook is missing urlQuery and navigate as dependencies. This can lead to unexpected behavior if these values change. Consider adding them to the dependency array.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  React hooks like useNavigate and custom hooks like useUrlQuery return stable references that don't change between renders. Adding them to the deps array would be unnecessary. The effect is specifically meant to sync with initialAccount changes, and the other values don't need to trigger the effect. The eslint-disable comment shows this was an intentional decision.
  I could be wrong about the stability of useUrlQuery - without seeing its implementation, I can't be 100% certain it returns a stable reference.
  Even if useUrlQuery returned an unstable reference, the current behavior is likely desired - we only want to update the URL when the initialAccount changes, not on every urlQuery change which could cause infinite loops.
  The comment should be deleted. The dependency array is intentionally set up this way, and adding the suggested dependencies could cause unnecessary re-runs or even infinite loops.

Workflow ID: wflow_9Vd6Tqf6ASKa0b9T

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.