-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua Cleanup #15705
Open
LarryFrosty
wants to merge
13
commits into
ShadowMario:main
Choose a base branch
from
LarryFrosty:fixing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lua Cleanup #15705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably looks kinda shitty lol whatever
yo thank u larry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getObjectLoop
toLuaUtils
(shortcut to splitting the variable and stuff)removeVar
getObjectLoop
. Some functions that didn't originally split will use it for conveniencegetObjectDirectly
to usegetTargetInstance
again instead ofMusicBeatState.getState
(literally why did this even get changed)(set/get)PropertyFromGroup
andremoveFromGroup
now uses Reflect for groups to fix sprite group errorsdoTweenColor
will now use the sprite's current alpha for the new color IF no alpha value is provided on the hex color. Should fix transparent sprites alpha going back to 1colorFromString
, if an alpha value is provided on the hex code (and starts with 0x), then it will subtract 8 instead of 6 to account for alphaleObj
's type to FlxBasic on(set/get)ObjectOrder
startTween
not holding the original tagantialiasing
as a Lua variableluaSoundExists
now formats the tagloadSong
now mutes opponent vocals