Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Eurus #167

Merged
merged 96 commits into from
Jan 24, 2025
Merged

[WIP] Eurus #167

merged 96 commits into from
Jan 24, 2025

Conversation

AlexPiche
Copy link
Collaborator

@AlexPiche AlexPiche commented Jan 11, 2025

Tests

  • Reproduce large DeepSeek run

Changes

  • Handle tensor and pipeline parallelism more gracefully.
  • Easily configurable task template and system prompt.
  • Train on the PRIME RL dataset.
  • Remove base_url: str | list[str] for base_url: str in the LLM class.
  • Comment out symbolic_equal since it was hanging and it is not compatible with our current version of hydra.
  • Improved and clean stats.
  • Implemented a is_debug_mode() in VLLMServiceManager
  • Add multiprocess support for dataset.map in finetune/data.py
  • Rename datasets to datasets_list to avoid conflict with the datasets library.
  • Normalize the loss to be over sequences and not tokens, i.e. replace masked_mean by masked_sum.
  • Refactor load_datasets.
  • Do not count the token of the prompt at every call.
  • Use the vllm tokenization for llm_call.prompt_length_tokens and llm_call.output_length_tokens
  • Assert that LLM does not produce more than cfg.llm.parameters.max_tokens
  • Truncate from the left long prompts

@AlexPiche AlexPiche changed the base branch from clamp_loss to better_batch_tapeagents January 13, 2025 21:46
Copy link
Collaborator

@rizar rizar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start looking pretty good! you can merge once you address all comments.

conf/rl_eurus.yaml Outdated Show resolved Hide resolved
examples/rl_gsm8k/cot_math_agent.py Outdated Show resolved Hide resolved
examples/rl_gsm8k/cot_math_agent.py Outdated Show resolved Hide resolved
examples/rl_gsm8k/deepseek_math_eval/eval_utils.py Outdated Show resolved Hide resolved
tapeagents/llms.py Show resolved Hide resolved
@AlexPiche AlexPiche merged commit d7258ba into main Jan 24, 2025
5 checks passed
@AlexPiche AlexPiche deleted the eurus branch January 24, 2025 03:26
@AlexPiche AlexPiche restored the eurus branch January 24, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants