Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reader support for DataBarLimited #159

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

Sec-ant
Copy link
Owner

@Sec-ant Sec-ant commented Oct 13, 2024

Details: zxing-cpp/zxing-cpp@5fadfbc

Summary by CodeRabbit

  • New Features
    • Added support for the new barcode format, "DataBarLimited," enhancing scanning capabilities.
  • Updates
    • Updated the zxing-wasm package to a new minor version, improving overall functionality.
    • Adjusted the sizes of WebAssembly binaries, optimizing performance.

Copy link

changeset-bot bot commented Oct 13, 2024

🦋 Changeset detected

Latest commit: 53aceb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
zxing-wasm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Oct 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request includes updates to the zxing-wasm package, featuring a version bump to reflect changes in the zxing-cpp package. The new barcode format "DataBarLimited" has been added to several components, including the barcodeFormats array and relevant interfaces. Additionally, type modifications have been made to the ReadInputBarcodeFormat and WriteInputBarcodeFormat. The sizes of the WebAssembly binaries have also been updated, reflecting changes in the package's structure and content.

Changes

File Path Change Summary
src/bindings/barcodeFormat.ts Added "DataBarLimited" to barcodeFormats; modified WriteInputBarcodeFormat to exclude it.
src/bindings/readResult.ts Updated format property in ReadResult interface to include "DataBarLimited".
src/bindings/readerOptions.ts Updated formats property in ReaderOptions interface to include "DataBarLimited".
zxing-wasm Version bumped to reflect changes in zxing-cpp from commit 81407a0... to daa502d6....
WebAssembly binaries Size updates: full from 1.06 MB to 1.19 MB, reader from 831 KB to 917 KB, writer from 313 KB to 366 KB.

Possibly related PRs

🐇 In the meadow, we hop and play,
New codes and formats brighten the day.
"DataBarLimited" joins the fun,
With version bumps, our work is done!
WebAssembly grows, oh what a sight,
Hopping along, everything feels right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pkg-pr-new bot commented Oct 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/zxing-wasm@159

commit: 53aceb3

@Sec-ant Sec-ant merged commit 925e12f into main Oct 13, 2024
7 checks passed
@Sec-ant Sec-ant deleted the feat/data-bar-limited branch October 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant