Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image to use github.url to allow testing of social media images #287

Merged

Conversation

mgriffin-scottlogic
Copy link
Contributor

@mgriffin-scottlogic mgriffin-scottlogic commented Dec 19, 2024

Fixes #285

No post associated with change, though I did make a test one to prove that a new image will now appear in the LinkedIn Post Inspector.

Screenshot 2024-12-19 104409

Have you (please tick each box to show completion):

  • Added your blog post to a single category?
  • Added a brief summary for your post? Summaries should be roughly two sentences in length and give potential readers a good idea of the contents of your post.
  • Checked that the build passes?
  • Checked your spelling (you can use npm install followed by npx mdspell "**/{FILE_NAME}.md" --en-gb -a -n -x -t if that's your thing)
  • Ensured that your author profile contains a profile image, and a brief description of yourself? (make it more interesting than just your job title!)
  • Optimised any images in your post? They should be less than 100KBytes as a general guide.

Posts are reviewed / approved by your Regional Tech Lead.

@robatwilliams robatwilliams self-requested a review January 6, 2025 10:27
Copy link
Contributor

@robatwilliams robatwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build pipeline issue, I guess unlikely to be due to this

@mgriffin-scottlogic
Copy link
Contributor Author

Build pipeline issue, I guess unlikely to be due to this

Yeah, we probably need to look into this at some point, I've seen it on a couple of PRs.

@mgriffin-scottlogic mgriffin-scottlogic merged commit 58b8e90 into ScottLogic:gh-pages Jan 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to preview social media images on forked repos
2 participants