Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odin@2024-12: Fix installation failing #2083

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anshul-bharat
Copy link

Odin installation fails

PS D:\git\Versions> scoop install odin
Installing 'odin' (2024-12) [64bit] from 'versions' bucket
Loading odin-windows-amd64-dev-2024-12.zip from cache
Checking hash of odin-windows-amd64-dev-2024-12.zip ... ok.
Extracting odin-windows-amd64-dev-2024-12.zip ... done.
Linking D:\Programs\scoop\apps\odin\current => D:\Programs\scoop\apps\odin\2024-12
Creating shim for 'odin'.
Get-Command : The term 'odin.exe' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name,
or if a path was included, verify that the path is correct and try again.
At D:\Programs\scoop\apps\scoop\current\lib\install.ps1:757 char:21
+             $bin = (Get-Command $target).Source
+                     ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (odin.exe:String) [Get-Command
   ], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException,Microsoft.PowerShell.
   Commands.GetCommandCommand

Can't shim 'odin.exe': File doesn't exist.

I updated bin path in manifest to include extra dist directory, since it was not matching with the directory structure inside package zip. which causes above error.

Same issue was occuring for odin-dev 2024-12 and odin-nightly 2024-12 updated them as well!

@anshul-bharat
Copy link
Author

/verify updated manifest to fix odin installation.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

odin-dev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

1 similar comment
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

odin-dev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@anshul-bharat
Copy link
Author

/verify updated manifest to fix odin installation.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

odin-dev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin-nightly

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Copy link
Contributor

@brian6932 brian6932 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./dist/ is the only directory, it should be the extract_dir, not added to the bin path.

bucket/odin-nightly.json Outdated Show resolved Hide resolved
bucket/odin-dev.json Outdated Show resolved Hide resolved
bucket/odin.json Outdated Show resolved Hide resolved
@brian6932
Copy link
Contributor

brian6932 commented Jan 3, 2025

fixes #1778
fixes #1805

Edit: just noticed the older PR.

@anshul-bharat
Copy link
Author

Applied suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants