Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable resistor component #346

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

langestefan
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add a variable resistor component with optional temperature dependency using a HeatPort.

Based on the potentiometer implementation from Modelica: https://doc.modelica.org/Modelica%203.2.3/Resources/helpWSM/Modelica/Modelica.Electrical.Analog.Basic.Potentiometer.html

However I named the component VariableResistor as opposed to potentiometer because the component has two ports, not three.

@ChrisRackauckas ChrisRackauckas merged commit f059237 into SciML:main Nov 28, 2024
4 of 12 checks passed
@langestefan langestefan deleted the potentiometer branch December 23, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants