Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to modify system after analysis point handling #316

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

baggepinnen
Copy link
Contributor

add ability to modify system after analysis point handling, but before linearization

This allows conversion to JuliaSimCompiler.IRSystem for the structural simplification

…ore linearization

This allows conversion to JuliaSimCompiler.IRSystem for the structural simplification
@ChrisRackauckas
Copy link
Member

Needs tests?

@baggepinnen
Copy link
Contributor Author

baggepinnen commented Aug 12, 2024

The intention is to make analysis points work with JuliaSimCompiler by passing system_modifier = IRSystem. I make use of this in Multibody so I will have some tests downstream (already have), but I don't think we want to add JSCompiler as a test dependency to test only this here.

100% of the diff in this PR is run in the tests already, there's just no tests for system_modifier != identity

@baggepinnen baggepinnen merged commit 8de0a39 into main Sep 2, 2024
6 of 8 checks passed
@baggepinnen baggepinnen deleted the system_modifier branch September 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants