test: added tests for SDEFunctionExpr #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sivasathyaseeelan <[email protected]>
test/sdesystem.jl
Outdated
| @test eval(SDEFunctionExpr(de).args[7]) == UniformScaling{Bool}(true) | ||
|
|
||
| # Test with non-trivial mass matrix | ||
| u0 = [1.0, 2.0, 3.0] |
There was a problem hiding this comment.
Why would this have a non-trivial mass matrix?
There was a problem hiding this comment.
non-trival mass matrix will test
_M = (u0 === nothing || M == I) ? M : ArrayInterface.restructure(u0 .* u0', M)the above condition in SDEFunctionExpr
There was a problem hiding this comment.
But this case doesn't have a non-trivial mass matrix. It's still identity.
There was a problem hiding this comment.
Oh got it
And I think we don't need to test Mass Matrix handling. As the above condition will be executed by default
Signed-off-by: sivasathyaseeelan <[email protected]>
|
@ChrisRackauckas can i get a review for this PR? |
ChrisRackauckas
approved these changes
Jan 21, 2025
|
Something is oddly failing here? |
Tests which i added were passing in my local machine. Are there any changes which i should make? |
|
Actually the failing test was unrelated... and I think hash consing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test for SDEFunctionExpr
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.