feat: use observed equations for guesses of observed variables #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
force-pushed
the
as/observed-guesses
branch
from
e572166 to
cd2518e
Compare
| @mtkbuild sys = ODESystem( | ||
| [D(x) ~ x + t, y ~ 2x + 1], t; initialization_eqs = [x^3 + y^3 ~ 1]) | ||
| isys = ModelingToolkit.generate_initializesystem(sys) | ||
| @test isequal(defaults(isys)[y], 2x + 1) |
There was a problem hiding this comment.
but in this case x doesn't have a guess, so how would it work?
There was a problem hiding this comment.
The system wasn't meant to be solved, just to ensure that y has a guess using the observed equation.
There was a problem hiding this comment.
I see but it's still not solvable?
There was a problem hiding this comment.
I can add a guess for x but I don't see how that helps the test 😅 the initializationsystem won't be solved during the test anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.