Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests #1070

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Fix broken tests #1070

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6879390
fix BK and HC tests
TorkelE Sep 27, 2024
f237e8d
up
TorkelE Sep 27, 2024
5e28124
disable SI docs
TorkelE Sep 29, 2024
4ed564f
add note in history file
TorkelE Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions test/extensions/bifurcation_kit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,35 @@ end
# Checks that the same bifurcation problem is created as for BifurcationKit.
# Checks with Symbolics as bifurcation and plot vars.
# Tries setting `jac=false`.
# Note: Only one parameter used, as tests technically depended on internal parameter ordering
# (Potentially the test should also be removed as it tests internal parameter stuff, however, test
# was written a while ago when I paid less attention to this kind of stuff.)
let
# Creates BifurcationProblem via Catalyst.
bistable_switch = @reaction_network begin
0.1 + hill(X,v,K,n), 0 --> X
d, X --> 0
0.1 + hill(X,5.0,K,3), 0 --> X
1.0, X --> 0
end
@unpack X, v, K, n, d = bistable_switch
@unpack X, K = bistable_switch
u0_guess = [X => 1.0]
p_start = [v => 5.0, K => 2.5, n => 3, d => 1.0]
p_start = [K => 2.5]
Comment on lines +65 to +70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do multiple parameters that are symbolic no longer work with the extension? Why do you need to change the parameters to hard-coded values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, still work (see other tests).

The problem is that I wrote a test which evaluates some internal MTK functions and check that they return the same stuff. However, this kind of depended on ordering, and the test fails due to the parameter ordering not being right. I changed the this test so that there was only a single parameter (so that parameter ordering is not really a worry).

Probably the test should just be removed instead, but for now I just tried to make a minimal change.

bprob = BifurcationProblem(bistable_switch, u0_guess, p_start, K; jac=false, plot_var=X)

# Creates BifurcationProblem via BifurcationKit.
function bistable_switch_BK(u, p)
X, = u
v, K, n, d = p
return [0.1 + v*(X^n)/(X^n + K^n) - d*X]
K, = p
return [0.1 + 5.0*(X^3)/(X^3 + K^3) - 1.0*X]
end
bprob_BK = BifurcationProblem(bistable_switch_BK, [1.0], [5.0, 2.5, 3, 1.0], (@lens _[1]); record_from_solution = (x, p) -> x[1])
bprob_BK = BifurcationProblem(bistable_switch_BK, [1.0], [2.5], (@lens _[1]); record_from_solution = (x, p) -> x[1])

# Check the same function have been generated.
bprob.u0 == bprob_BK.u0
bprob.params == bprob_BK.params
for repeat = 1:20
u0 = rand(rng, 1)
p = rand(rng, 4)
@test bprob_BK.VF.F(u0, p) == bprob.VF.F(u0, p)
p = rand(rng, 1)
@test bprob_BK.VF.F(u0, p) ≈ bprob.VF.F(u0, p)
end
end

Expand Down
4 changes: 2 additions & 2 deletions test/extensions/homotopy_continuation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ let
v*(0.1/v + hill(X,1,K,n)), 0 --> X
d, X --> 0
end
ps = [:v => 5.0, :K => 2.5, :n => 3, :d => 1.0]
ps = Dict([:v => 5.0, :K => 2.5, :n => 3, :d => 1.0])
sss = hc_steady_states(rs, ps; filter_negative = false, show_progress = false, seed = 0x000004d1)

@test length(sss) == 4
for ss in sss
@test f_eval(rs,sss[1], last.(ps), 0.0)[1] ≈ 0.0 atol = 1e-12
@test ps[:v]*(0.1/ps[:v] + ss[1]^ps[:n]/(ss[1]^ps[:n] + ps[:K]^ps[:n])) - ps[:d]*ss[1]≈ 0.0 atol = 1e-12
end

ps = [:v => 5.0, :K => 2.5, :n => 2.7, :d => 1.0]
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ using SafeTestsets, Test
# Tests extensions.
@time @safetestset "BifurcationKit Extension" begin include("extensions/bifurcation_kit.jl") end
@time @safetestset "HomotopyContinuation Extension" begin include("extensions/homotopy_continuation.jl") end
@time @safetestset "Structural Identifiability Extension" begin include("extensions/structural_identifiability.jl") end
# @time @safetestset "Structural Identifiability Extension" begin include("extensions/structural_identifiability.jl") end

# Tests stability computation (uses HomotopyContinuation extension).
@time @safetestset "Steady State Stability Computations" begin include("miscellaneous_tests/stability_computation.jl") end
Expand Down
Loading