Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1185 wrong index in ode seir model #1186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kilianvolmer
Copy link

@kilianvolmer kilianvolmer commented Jan 13, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Fixed wrong index in model.h of ODE SEIR model
  • Added test to test_odeseir.cpp that would have failed with the previous wrong index

If need be, add additional information and what the reviewer should look out for in particular:

Closes #1185 .

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@kilianvolmer kilianvolmer requested a review from HenrZu January 13, 2025 14:09
@kilianvolmer kilianvolmer self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (8958e31) to head (f3e8888).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         148      148           
  Lines       13718    13718           
=======================================
  Hits        13303    13303           
  Misses        415      415           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for findings this typo. Just one short comment. Then we can merge this :)

cpp/tests/test_odeseir.cpp Outdated Show resolved Hide resolved
@kilianvolmer kilianvolmer requested a review from HenrZu January 15, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong index in ODE_SEIR model
2 participants