Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inside demonstrator munich #1169

Open
wants to merge 114 commits into
base: main
Choose a base branch
from
Open

Inside demonstrator munich #1169

wants to merge 114 commits into from

Conversation

jubicker
Copy link
Member

@jubicker jubicker commented Jan 2, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Inside demonstrator for munich

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

xsaschako and others added 30 commits March 17, 2023 10:12
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Signed-off-by: Sascha Korf <[email protected]>
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 65.30055% with 127 lines in your changes missing coverage. Please review.

Project coverage is 95.06%. Comparing base (f192ec6) to head (afc0f4b).

Files with missing lines Patch % Lines
cpp/models/abm/analyze_result.h 0.00% 79 Missing ⚠️
cpp/models/abm/parameters.h 78.67% 29 Missing ⚠️
cpp/models/abm/infection.cpp 87.82% 14 Missing ⚠️
cpp/models/abm/person.cpp 83.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   96.97%   95.06%   -1.91%     
==========================================
  Files         148      148              
  Lines       13718    13811      +93     
==========================================
- Hits        13303    13130     -173     
- Misses        415      681     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants