Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong index in ODE_SEIR model #1185

Open
2 tasks done
kilianvolmer opened this issue Jan 13, 2025 · 0 comments · May be fixed by #1186
Open
2 tasks done

Wrong index in ODE_SEIR model #1185

kilianvolmer opened this issue Jan 13, 2025 · 0 comments · May be fixed by #1186
Assignees
@kilianvolmer
Labels
class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::moderate The priority of this task is moderate. status::in progress This issue is in progess.

Comments

@kilianvolmer
Copy link

Bug description

In https://github.com/SciCompMod/memilio/blob/main/cpp/models/ode_seir/model.h#L83 the index j instead of i should be used.

Version

Any

To reproduce

Run an ODE_SEIR model with more than one age group.

Relevant log output

No response

Add any relevant information, e.g. used compiler, screenshots.

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@kilianvolmer kilianvolmer added class::bug Bugs found in the software prio::moderate The priority of this task is moderate. status::in progress This issue is in progess. loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. labels Jan 13, 2025
@kilianvolmer kilianvolmer self-assigned this Jan 13, 2025
@kilianvolmer kilianvolmer moved this from Product Backlog to 🏗 Development in MEmilio: Equation-Based-Models Development Jan 13, 2025
@kilianvolmer kilianvolmer linked a pull request Jan 13, 2025 that will close this issue
Open
12 tasks
@kilianvolmer kilianvolmer moved this from 🏗 Development to 👀 Review in MEmilio: Equation-Based-Models Development Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kilianvolmer kilianvolmer

Labels
class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::moderate The priority of this task is moderate. status::in progress This issue is in progess.
Projects
MEmilio: Equation-Based-Models Development
Status: 👀 Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1185 wrong index in ode seir model SciCompMod/memilio
1 participant
@kilianvolmer