Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add csv-based infrastructure repository #21

Merged
merged 15 commits into from
Dec 5, 2024
Merged

feat: add csv-based infrastructure repository #21

merged 15 commits into from
Dec 5, 2024

Conversation

munterfi
Copy link
Member

@munterfi munterfi commented Dec 3, 2024 •
edited
Loading

  • InfrastructureRepository implementation for reading a CSV source.
  • Utility to calculate great-circle distance using haversine formula.
  • Adjusted command line application.
  • Add stop_facility_info.csv for test cases.

Supports CSV repos of the following format:

  • stop_facility_info.csv:
stop_id,stop_name,stop_lat,stop_lon
AA,Aarau,47.39143907048071,8.051261316066457
AL,Altdorf UR,46.87608653091944,8.631501919754012
...
  • rolling_stock_info.csv:
category,vehicle_type_id,seats,standing_room,length,max_velocity
IC,FV-Dosto,600,0,200,200
IR,IR-Dosto,350,550,100,160
...

@munterfi
feat: add csv-based infrastructure repository
ddd3d35 
- InfrastructureRepository implementation for reading a CSV source.
- Utility to calculate great-circle distance using haversine formula.
- Adjusted command line application.
- Add stop_facility_info.csv for test cases.
@munterfi munterfi self-assigned this Dec 3, 2024
@munterfi munterfi linked an issue Dec 3, 2024 that may be closed by this pull request
Feature: Repository Implementations for CSV Files #20
Closed
@munterfi munterfi marked this pull request as draft December 3, 2024 20:15
munterfi added 13 commits December 4, 2024 10:13
@munterfi
test: add stop facility info for realistic scenario in Switzerland
24e09e6
@munterfi
refactor: move test cases to util/test package
e8d4d0e
@munterfi
feat: remove deprecated constructor of BOMInputStream
0e0047d 
- Read and set the stop facility name.
@munterfi
feat: use stop name of stop facility
bc5039c 
- Read full name field as stop name from network graphic.
- Use stop name to construct long route name in GTFS.
- Adjust all tests.
@munterfi
feat: extend validation strategies for network graphic ids
1715348 
- REPLACE_WHITESPACE: Strips the string and replaces intermediate whitespace with underscores.
- REMOVE_SPECIAL_CHARACTERS: Removes all special characters, including whitespace.
@munterfi
test: set real operational code names in stop facility info CSV
717a621
@munterfi
test: move stop facility infos
31b6582
@munterfi
refactor: introduce conversion service request object
384c5b3
@munterfi
test: add special characters and whitespace to node ids
175d217 
- Fixes fail on issue validation test.
- Covers all validation cases.
@munterfi
feat: add rolling stock CSV repository implementation
69eb81a 
- Add standing room to vehicle type.
- Rename capacity to seats.
@munterfi
reformat: extract duplicated CSV reader code into abstract base class
5b62854
@munterfi
feat: add command line option to use a rolling stock CSV repo
5607044
@munterfi
doc: update readme with information about the usage of the CSV reposi…
4f6a2aa 
…tories
@munterfi munterfi marked this pull request as ready for review December 5, 2024 15:39
@munterfi munterfi merged commit 87425bc into main Dec 5, 2024
3 checks passed
@munterfi munterfi deleted the feature/20-feature-repository-implementations-for-csv-files branch December 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@munterfi munterfi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Repository Implementations for CSV Files
1 participant
@munterfi