Replace node-sass (deprecated) with sass (recommended)
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node-sass` has been deprecated for a couple of years and it's always had a ton of issues installing correctly in different node environments. The docs now recommend using dart-sass instead, which is the actively maintained official sass compiler. This PR swaps out one for the other. I also ran the included format script. Going to let tests run in CI because I think I'm running into weird behavior with directory changing on Windows which is causing the last two tests to fail. Hopefully this allows people to continue to use fiddly even on the latest versions of node!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to a Personal Account owned by @SaraVieira on Vercel. @SaraVieira first needs to authorize it. |
|
Ahh, this project is so old now so many things need updating! Updated additional configs where I could, but I don't think I can get these checks to pass on my own. Vercel specifically seems to be failing on a more recent JS string API, Added a GitHub Actions test config setup to run against Node 12, 14, 16, and 18 too. Don't think it will run until merged however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sasshas been deprecated for a couple of years and it's always had a ton of issues installing correctly in different node environments.The docs now recommend using dart-sass instead, which is the actively maintained official sass compiler. This PR swaps out one for the other.
I also ran the included format script. Going to let tests run in CI because I think I'm running into weird behavior with directory changing on Windows which is causing the last two tests to fail.
Hopefully this allows people to continue to use fiddly even on the latest versions of node!