Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Add IsAutoRotationEnabled, IsLetterBoxEnabled #6573

Open
wants to merge 1 commit into
base: DevelNUI
Choose a base branch
from

Conversation

JoogabYun
Copy link
Contributor

@JoogabYun JoogabYun commented Jan 13, 2025

Description of Change

If Underlay=false is set, the tbm buffer of the media packet is displayed on the screen as is.
So, if the video content is rotated, it is displayed on the screen as rotated.

  1. Setting IsAutoRotationEnabled to true automatically rotates video content.
  2. If you set IsLetterBoxEnabled to true, it will display the video content proportionally on the screen.

https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/317900
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/317901
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/317903
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-extension/+/317902

API Changes

  • ACR:

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.VideoView::AutoRotation()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.VideoView::LetterBox()

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.VideoView::IsAutoRotationEnabled()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.BaseComponents.VideoView::IsLetterBoxEnabled()

Copy link
Collaborator

@rabbitfor rabbitfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoogabYun JoogabYun changed the title [NUI] Add AutoRotation, LetterBox [NUI] Add IsAutoRotationEnabled, IsLetterBoxEnabled Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants