[NUI.AIAvatar] Complete refactor for enhanced modularity and customiz… #6487

AnglerLee · 2024-12-02T06:56:08Z

Description of Change

Reorganized entire project structure for improved clarity and maintainability.
Introduced customizable interfaces for AI functionalities, allowing seamless integration of third-party modules.
Optimized existing code base for increased efficiency and reduced redundancy.

- NUI Autofill code was not removed together with dali ones. - Now, all related codes should be deleted because there's no use case anywhere and they don't have their internal implementation. Signed-off-by: Seoyeon Kim <[email protected]>

… is cleared. (#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/

- `CSharp_Dali_ViewImpl_AccessibilityActivate` was removed in 2018 lol However, at that time, NUI codes couldn't be removed together (Not sure) - The reason `ViewImpl_AccessibilityActivate` was removed is `Remove functions which using internal apis Some binding functions use internal apis. It caused error when dlopen csharp binder.` - User can use Activated event with `View.AccessibilityActivated` Signed-off-by: Seoyeon Kim <[email protected]>

* [WebRTC] Change state restriction

Let we support to BoxShadow and ColorVisual, to ignore rendering inside of View area. None is default, same as previous logics. CutoutView is cutout render area as bounding box of view. It is faster than CutoutViewWithCornerRadius. CutoutWithCornerRadius is cutout render area consider the corner radius of view. Required dali patch : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/314255 Signed-off-by: Eunki, Hong <[email protected]>

- Make intention revealing names for Some variables. Choosing names that reveal intent can make it much easier to understand. Signed-off-by: Seoyeon Kim <[email protected]>

this patch supports cornerRadius in WebView refer to : https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/304770/

System.Reflection.Assembly.CreateInstance() can return null value. Signed-off-by: Sangyoon Jang <[email protected]>

This patch changes internal tensor size limit in MachineLearning.Inference. Tizen Native ML api's max tensor size has been changed to 256. Signed-off-by: Yelin Jeong <[email protected]>

Signed-off-by: Seungho Baek <[email protected]>

Use this when you want to know the status value of a pan gesture. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-core/+/315444/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/315445/ https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-csharp-binder/+/315446/

Since some useless animation was running internally until GC comes, CPU usage might be increased for this sample. To avoid useless rendering, let we ensurely dispose not-using animation. Signed-off-by: Eunki, Hong <[email protected]>

Make we use unified code style when we connect/disconnect native signal to C# EventHandler. It will be reduce some copy-paste the non-common style implementation. This PR will change below classes * (internal)Application and it's family * (internal)ObjectRegistry * (internal)Builder * (internal)GaussianBlurView * ImageView and it's family * View, ViewAccessibility * Clipboard * Capture Signed-off-by: Eunki, Hong <[email protected]>

Signed-off-by: Seungho Baek <[email protected]>

Co-authored-by: Woochan Lee <[email protected]>

…view Until now, VisibilityChangedEventArgs.View return sender itself. It is useless information for user. Follow up some other platform's behavior, ( reference : https://developer.android.com/reference/android/view/View#onVisibilityChanged(android.view.View,%20int) ) Let we make VisibilityChangedEventArgs.View return visibility changed view. Relative dali patch : - https://review.tizen.org/gerrit/c/platform/core/uifw/dali-core/+/315475 - https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/315484 Signed-off-by: Eunki, Hong <[email protected]>

Found some build warning list by below command dotnet build /p:BuildWithAnalyzer=True -consoleloggerparameters:NoSummary Their are too many warnings occurs, let we remove them by multiple phases. Signed-off-by: Eunki, Hong <[email protected]>

- TCT crash issue, log => E/STDERR (21795): Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object. E/STDERR (21795): at Tizen.NUI.BaseComponents.View.Dispose(DisposeTypes type) in Tizen.NUI.dll:token 0x6002b7c+0x591 E/STDERR (21795): at Tizen.NUI.BaseHandle.Dispose() in Tizen.NUI.dll:token 0x6000e5c+0xc E/STDERR (21795): at Tizen.NUI.DisposeQueue.ProcessDisposablesIncrementally() in Tizen.NUI.dll:token 0x6000238+0x79 E/STDERR (21795): at Tizen.NUI.DisposeQueue.ProcessDisposables() in Tizen.NUI.dll:token 0x6000237+0xd5 E/STDERR (21795): onSigabrt called

Apply some comments that report at PR #6079 - `Color.A` getter apply `Opacity` changeness - Make `VisualFittingMode` have no effect for `ColorVisual` and `BorderVisual` - `GetVisualProperty` return valid value after call `GetCurrentVisualProperty` - Make `VisualBase` class as abstract. Let we don't allow to call this class constructor. Signed-off-by: Eunki, Hong <[email protected]>

Add SynchrousSizing property - reload as size of visual. It will be useful when we want to load image as specific size of view, so the memory is reduced. Signed-off-by: Eunki Hong <[email protected]>

Signed-off-by: Seoyeon Kim <[email protected]>

Requests asynchronous rendering of text with a fixed size. Signed-off-by: Bowon Ryu <[email protected]>

TizenAPI-Bot · 2024-12-02T07:44:45Z

Public API Changed

Please follow the ACR process for the changed API below.
Added: 236, Removed: 0, Changed: 0

Internal API Changed

Added: 14, Removed: 199, Changed: 0

hinohie

Please add Hidden tag before open ACR.

hinohie · 2024-12-02T09:10:15Z

src/Tizen.AIAvatar/Tizen.AIAvatar.csproj

    <ProjectReference Include="..\Tizen\Tizen.csproj" />
    <ProjectReference Include="..\Tizen.Log\Tizen.Log.csproj" />
    <ProjectReference Include="..\Tizen.Uix.Tts\Tizen.Uix.Tts.csproj" />
    <ProjectReference Include="..\Tizen.NUI\Tizen.NUI.csproj" />
    <ProjectReference Include="..\Tizen.NUI.Scene3D\Tizen.NUI.Scene3D.csproj" />
-    <ProjectReference Include="..\Tizen.MachineLearning.Inference\Tizen.MachineLearning.Inference.csproj" />
+    <ProjectReference Include="..\Tizen.MachineLearning.Inference\Tizen.MachineLearning.Inference.csproj" />    


Suggested change

<ProjectReference Include="..\Tizen.MachineLearning.Inference\Tizen.MachineLearning.Inference.csproj" />

<ProjectReference Include="..\Tizen.MachineLearning.Inference\Tizen.MachineLearning.Inference.csproj" />

Minor. Remove this tab

Thank you. I will modify the code.

dongsug-song · 2024-12-02T11:17:03Z

@AnglerLee
아래와 같은 Bot comment 가 있습니다.
이것은 public api 가 추가,삭제,변경 되었을때 ACR 이 필요해서 뜨는 것입니다.

Please follow the ACR process for the changed API below.
Added: 236, Removed: 0, Changed: 0

TCSACR 을 진행하셔야 될 것 같습니다.
예시) https://jira.sec.samsung.net/browse/TCSACR-586

@jaehyun0cho
@Seoyeon2Kim
@taehyub
@lwc0917
안녕하세요.
패치가 큰데요, 리뷰 부탁드립니다.

AnglerLee · 2024-12-03T00:05:52Z

리팩토링 이후 충분한 리뷰를 거치지 못해서요.
일단 Hidden으로 처리하고 완성도를 높인 후에 ACR 진행 하도록 하겠습니다!
감사합니다.

TizenAPI-Bot · 2024-12-03T02:52:00Z

Internal API Changed

Added: 250, Removed: 199, Changed: 0

Seoyeon2Kim

Wow this PR is very huge.
I'll read the rest soon.

Seoyeon2Kim · 2024-12-10T02:57:39Z

src/Tizen.AIAvatar/src/AIServices/Core/AIServiceData.cs

+        /// Gets or sets the size of the current audio data chunk in bytes.
+        /// </summary>
+        [EditorBrowsable(EditorBrowsableState.Never)]
+        public int AudioBytes { get; set; }


Just my curiosity :
I'm not familiar with AI Avatar actually, so could you explain why this type is int, not byte array like the above (AudioData) please?

The variables AudioBytes, TotalBytes, and ProcessedBytes are all declared as 'int' because they represent the size of processed audio data. The actual audio data is stored in a variable named AudioData which is declared as a byte array.

Seoyeon2Kim · 2024-12-10T02:58:30Z

src/Tizen.AIAvatar/src/AIServices/Core/Prompt.cs

+using System.Text;
+using System.Threading.Tasks;
+
+namespace Tizen.AIAvatar.Samsung


Minor.
@dongsug-song , is it okay to add Samsung suffix for TizenFX coding convention?

I apologize for the mistake in adding a suffix. I will correct it right away.

Seoyeon2Kim · 2024-12-10T03:05:16Z

src/Tizen.AIAvatar/src/AIServices/OpenAIService.cs

+                    model = "tts-1",
+                    input = text,
+                    voice = voice ?? "alloy",
+                    response_format = "pcm",  // PCM 포맷으로 변경


Might be this Korean comment not be updated yet?

I will remove the comments for clean code. I'll make the changes. 😄

TizenAPI-Bot · 2024-12-11T00:42:36Z

Internal API Changed

Added: 259, Removed: 199, Changed: 0

…enaming them accordingly for better code organization and readability.

TizenAPI-Bot · 2024-12-12T03:09:54Z

Internal API Changed

Added: 263, Removed: 199, Changed: 0

…internal variables, so I changed the values of the structure to public.

AnglerLee · 2024-12-13T03:00:30Z

I have documented the implementation of AIAvatar refactoring. Please refer to the following for review:
[Implementation] (https://confluence.sec.samsung.net/pages/viewpage.action?pageId=975063819)
[Sample & Test] (https://confluence.sec.samsung.net/pages/viewpage.action?pageId=975063825)

TizenAPI-Bot · 2024-12-13T03:01:32Z

Internal API Changed

Added: 263, Removed: 199, Changed: 0

dongsug-song · 2024-12-18T01:07:06Z

@AnglerLee
Hello,
The TizenFX main branch has been changed for API13 (tizen_10).
So the DevelNUI branch also did a hard reset with the master branch to sync this.
I think you need to rebase this PR or re-upload the new PR.
I am sorry for the inconvenience.

Seoyeon2Kim and others added 30 commits July 18, 2024 14:32

[NUI] Revert the legacy Autofill code

8b82935

- NUI Autofill code was not removed together with dali ones. - Now, all related codes should be deleted because there's no use case anywhere and they don't have their internal implementation. Signed-off-by: Seoyeon Kim <[email protected]>

Revert "[NUI] If the view had focus when it was unparented, the focus…

2bfca46

… is cleared. (#4654)" This reverts commit 09f52bc. This operation is moved to the DALi. https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/314664/

[NUI] NUI Version up(nui22333)

cb6e861

[WebRTC] Change state restriction (#6181)

a1db665

* [WebRTC] Change state restriction

[NUI] Support View BackgroundBlurEffect

2c4547f

[NUI] Clean code for NUI Layouting (#6238)

fefd509

- Make intention revealing names for Some variables. Choosing names that reveal intent can make it much easier to understand. Signed-off-by: Seoyeon Kim <[email protected]>

[NUI] Add WebView APIs for fullscreen, text found, etc.

e6cfbc5

[NUI] Create Context/CookieManager when WebView is created.

ddde596

[NUI] Support CornerRadius in WebView

33ee838

this patch supports cornerRadius in WebView refer to : https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-toolkit/+/304770/

[NUI] Add a WebView API for notifying orientation change.

06032c2

[Tdbc] Fix static analysis issue (#6228)

7d1ffce

System.Reflection.Assembly.CreateInstance() can return null value. Signed-off-by: Sangyoon Jang <[email protected]>

[NoACR][MachineLearning.Inference] Change internal tensor size limit

14d3f14

This patch changes internal tensor size limit in MachineLearning.Inference. Tizen Native ML api's max tensor size has been changed to 256. Signed-off-by: Yelin Jeong <[email protected]>

[NUI] Version update(22334)

efb8793

[NUI] Add Exclusive Option for Capture

b77a943

Signed-off-by: Seungho Baek <[email protected]>

[NUI] Add InheritedVisibilityChanged Event

5839c92

Signed-off-by: Seungho Baek <[email protected]>

[NUI] Version upate(22335) (#6253)

d4cfb01

Co-authored-by: Woochan Lee <[email protected]>

[NUI] Bind SynchronousSizing for ImageView / ImageVisual

1a121d4

Add SynchrousSizing property - reload as size of visual. It will be useful when we want to load image as specific size of view, so the memory is reduced. Signed-off-by: Eunki Hong <[email protected]>

[NUI] Version Update (22336)

f9b5432

Signed-off-by: Seoyeon Kim <[email protected]>

[MediaContent] Deprecate all Bookmark and Playlist APIs (#6240)

e0f1751

[WebRTC] Add debug log (#6256)

62f74c2

[NUI] Add RequestAsyncRenderWithFixedSize to text label

5c40f1b

Requests asynchronous rendering of text with a fixed size. Signed-off-by: Bowon Ryu <[email protected]>

bugfix. Path.Combine (avatar.dir + avatar.filename)

f481b96

hinohie reviewed Dec 2, 2024

View reviewed changes

dongsug-song requested review from taehyub, rabbitfor, jaehyun0cho, everLEEst, Seoyeon2Kim and lwc0917 December 2, 2024 10:52

Angler added 3 commits December 3, 2024 11:35

Before ACR processing, a hidden tag has been added. (Tizen.AIAvatar)

877270c

Before ACR processing, a hidden tag has been added. (Tizen.NUI.AIAvatar)

2c811d8

I removed unnecessary tabs for clean code.

34d5631

TizenAPI-Bot removed the ACR Required label Dec 3, 2024

dongsug-song added the detailed and in-depth review required label Dec 3, 2024

Seoyeon2Kim reviewed Dec 10, 2024

View reviewed changes

I have removed comments and corrected misnamed variables for clean code.

e442cfd

Refactoring streaming audio play functions to be public/private and r…

f8ac090

…enaming them accordingly for better code organization and readability.

Bug fix: System.Text.Json.JsonSerializer couldn't deserialize due to …

860c72b

…internal variables, so I changed the values of the structure to public.

dongsug-song force-pushed the DevelNUI branch from aab74ad to 2217d8a Compare December 18, 2024 01:02

dongsug-song requested a review from wonrst as a code owner December 18, 2024 01:02

AnglerLee closed this Dec 23, 2024

Seoyeon2Kim mentioned this pull request Dec 27, 2024

[NUI.AIAvatar] AI Avatar Refactoring Complete. #6526

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NUI.AIAvatar] Complete refactor for enhanced modularity and customiz… #6487

[NUI.AIAvatar] Complete refactor for enhanced modularity and customiz… #6487

AnglerLee commented Dec 2, 2024

TizenAPI-Bot commented Dec 2, 2024

hinohie left a comment

hinohie Dec 2, 2024

AnglerLee Dec 3, 2024 •

edited

Loading

dongsug-song commented Dec 2, 2024

AnglerLee commented Dec 3, 2024

TizenAPI-Bot commented Dec 3, 2024

Seoyeon2Kim left a comment

Seoyeon2Kim Dec 10, 2024

AnglerLee Dec 11, 2024

Seoyeon2Kim Dec 10, 2024

AnglerLee Dec 11, 2024

Seoyeon2Kim Dec 10, 2024

AnglerLee Dec 11, 2024

TizenAPI-Bot commented Dec 11, 2024

TizenAPI-Bot commented Dec 12, 2024

AnglerLee commented Dec 13, 2024

TizenAPI-Bot commented Dec 13, 2024

dongsug-song commented Dec 18, 2024

	<ProjectReference Include="..\Tizen.MachineLearning.Inference\Tizen.MachineLearning.Inference.csproj" />
	<ProjectReference Include="..\Tizen.MachineLearning.Inference\Tizen.MachineLearning.Inference.csproj" />

[NUI.AIAvatar] Complete refactor for enhanced modularity and customiz… #6487

[NUI.AIAvatar] Complete refactor for enhanced modularity and customiz… #6487

Conversation

AnglerLee commented Dec 2, 2024

Description of Change

TizenAPI-Bot commented Dec 2, 2024

Public API Changed

Internal API Changed

hinohie left a comment

Choose a reason for hiding this comment

hinohie Dec 2, 2024

Choose a reason for hiding this comment

AnglerLee Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

dongsug-song commented Dec 2, 2024

AnglerLee commented Dec 3, 2024

TizenAPI-Bot commented Dec 3, 2024

Internal API Changed

Seoyeon2Kim left a comment

Choose a reason for hiding this comment

Seoyeon2Kim Dec 10, 2024

Choose a reason for hiding this comment

AnglerLee Dec 11, 2024

Choose a reason for hiding this comment

Seoyeon2Kim Dec 10, 2024

Choose a reason for hiding this comment

AnglerLee Dec 11, 2024

Choose a reason for hiding this comment

Seoyeon2Kim Dec 10, 2024

Choose a reason for hiding this comment

AnglerLee Dec 11, 2024

Choose a reason for hiding this comment

TizenAPI-Bot commented Dec 11, 2024

Internal API Changed

TizenAPI-Bot commented Dec 12, 2024

Internal API Changed

AnglerLee commented Dec 13, 2024

TizenAPI-Bot commented Dec 13, 2024

Internal API Changed

dongsug-song commented Dec 18, 2024

AnglerLee Dec 3, 2024 •

edited

Loading