Reduce calls to list-topics #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ListTopics only returns topics in batches of 100 and it gets rate limited, reduce paths that would call this API endpoint. - Get the topic ARN from elsewhere. - Call CreateTopic (which is idempotent) and use the returned ARN.
florianpilz
approved these changes
Nov 8, 2023
Comment on lines
+24
to
26
| arn = @@topic_arns[topic_key] | ||
| unless arn | ||
| response = sns.create_topic(name: aws_safe_name(_event_type)) |
There was a problem hiding this comment.
Really great spot, that should improve performance as lot :)
Creates a topic to which notifications can be published. Users can create at most 100,000 standard topics (at most 1,000 FIFO topics). For more information, see Creating an Amazon SNS topic in the Amazon SNS Developer Guide . This action is idempotent, so if the requester already owns a topic with the specified name, that topic's ARN is returned without creating a new topic.
There was a problem hiding this comment.
Thanks! I'm still worried someone was depending on weird behaviour, so I'll cut a major version just to be safe. I like to believe there was a reason for the previous approach... 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ListTopics only returns topics in batches of 100 and it gets rate limited, reduce paths that would call this API endpoint.