Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bug fixes #383

Merged
merged 18 commits into from
Apr 20, 2024
Merged

UI bug fixes #383

merged 18 commits into from
Apr 20, 2024

Conversation

cayb0rg
Copy link
Contributor

@cayb0rg cayb0rg commented Apr 16, 2024

Summary

  • Adds GitHub Link to top right of page (Hovering over it will show the "Report an issue" tooltip)
  • Fixes FP Register display/parsing for Floats and Doubles
  • Re-orders stack frame view so that new frames appear on top, as to be consistent with the memory views
  • Fixes hex selection highlighting the wrong ASCII characters
  • Adds hex highlighting when selecting ASCII characters
  • Editing ASCII section in hex editor will now also update memory
  • Re-writes the MIPS disassembly function to use try_from for simplifying field fetching
  • Adds tests for disassembling MIPS instructions including FpuRType, FpuIType, FpuRegImmType, FpuCompareType, FpuBranchType
    • sll instruction was only able to decode properly as sll rd rt sa, not sll rt rs sa, so I updated the hover instruction
    • Disassembling MIPS jal instruction now correctly assigns the label
      • Disassembling beq and bne is still not done because these use relative labels
  • Adds tests for disassembling RISC-V instructions
    • Jump and branch instructions work except for getting the offset/address - since these are dependent on the current address, it was not possible to test.
  • Fixed Call Line link in the Stack Frame view being one line off in the code editor
  • Removes my development logs
  • Re-enables the Assemble button after assembling (which just resets and assembles again)
  • Greys out execute on parser errors (Issue Grey out execute when parser output to memory changes #234 )

@cayb0rg cayb0rg marked this pull request as ready for review April 19, 2024 01:29
@brooksmckinley brooksmckinley merged commit 6179ba3 into swim-v2 Apr 20, 2024
1 check passed
@brooksmckinley brooksmckinley deleted the ui-bug-fixes branch April 20, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants