Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data export engine #1272

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Add data export engine #1272

merged 8 commits into from
Jan 21, 2025

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Jan 15, 2025

Description

Add new engine data export

Add tests for data export engine actions

How to test

Run the tests should all pass

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

@jesusbv jesusbv self-assigned this Jan 15, 2025
@jesusbv
Copy link
Collaborator Author

jesusbv commented Jan 15, 2025

Keep in mind that this engines needs changes in ZypperAuth code, so waiting for #1270 to be merged to update this

It can be reviewed in the meantime

engines/data_export/lib/data_export/engine.rb Outdated Show resolved Hide resolved
engines/data_export/lib/data_export/engine.rb Outdated Show resolved Hide resolved
engines/data_export/lib/data_export/engine.rb Outdated Show resolved Hide resolved
engines/data_export/lib/tasks/data_warehouse_tasks.rake Outdated Show resolved Hide resolved
Copy link
Member

@rjschwei rjschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve after #1274 is merged. The usage instructions provided may not be correct, please double check.

jesusbv and others added 6 commits January 20, 2025 13:23
Add tests for data export engine actions
- Provide a description for use of the data export engine and how to use it
- Rename the update_info interface of the export engine to export_rmt_data
@digitaltom digitaltom merged commit b9a9240 into master Jan 21, 2025
3 checks passed
@digitaltom digitaltom deleted the dw-engine branch January 21, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants